Bug 1935174: bump RHCOS boot image for LUKS fixes by miabbott · Pull Request #4746 · openshift/installer

miabbott · 2021-03-12T14:16:03Z

This bumps the RHCOS boot images to address the LUKS problem
described in RHBZ#1934863

This bumps the RHCOS boot images to address the LUKS problem described in RHBZ#1934863

openshift-ci-robot · 2021-03-12T14:16:10Z

@miabbott: This pull request references Bugzilla bug 1935174, which is invalid:

expected the bug to target the "4.7.z" release, but it targets "4.8.0" instead
expected dependent Bugzilla bug 1934557 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
expected dependent Bugzilla bug 1934863 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
expected dependent Bugzilla bug 1934863 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1935174: bump RHCOS boot image for LUKS fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miabbott · 2021-03-12T14:16:42Z

Depends on #4745 getting merged/verified

staebler

/approve

openshift-ci-robot · 2021-03-12T20:39:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

miabbott · 2021-03-15T19:43:10Z

/retest

With 4.6 bundles, /dev/vda4 was automatically extended at startup to fill unused disk space. This no longer happens in 4.7, possibly until openshift/installer#4746 is fixed. This makes the xfs_growfs call in crc ineffective, as /dev/vda4 still has its initial size. This commit makes crc grow the partition itself until this bug is fixed.

With 4.6 bundles, /dev/vda4 was automatically extended at startup to fill unused disk space. This no longer happens in 4.7, possibly until openshift/installer#4746 is fixed. This makes the xfs_growfs call in crc ineffective, as /dev/vda4 still has its initial size. This commit makes crc grow the partition itself until this bug is fixed. This fixes crc-org#2104

miabbott · 2021-03-16T15:26:41Z

TL;DR - test failures do not look like they were introduced with this change

e2e-metal-assisted is pretty red lately; showing the following failure in most recent runs:

TypeError: __init__() got an unexpected keyword argument 'static_network_config'
make: *** [Makefile:295: _deploy_nodes] Error 1
make: *** [Makefile:299: deploy_nodes_with_install] Error 2
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-03-15T13:39:03Z"}
error: failed to execute wrapped command: exit status 2

Probably needs a new BZ.

e2e-kubevirt looks to be permafailing as of late.

e2e-aws is failing on [sig-auth][Feature:SCC][Early] should not have pod creation failures during install [Suite:openshift/conformance/parallel]

Sippy lead me to https://bugzilla.redhat.com/show_bug.cgi?id=1913069

e2e-metal-ipi-ovn-dualstack failing on [sig-api-machinery] CustomResourcePublishOpenAPI [Privileged:ClusterAdmin] works for CRD preserving unknown fields in an embedded object [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]

Seems like it has been present in various other CI jobs over the last 7 days; will file a BZ for it.

miabbott · 2021-03-16T15:26:48Z

/assign jlebon

miabbott · 2021-03-16T15:27:00Z

/bugzilla refresh

openshift-ci-robot · 2021-03-16T15:27:05Z

@miabbott: This pull request references Bugzilla bug 1935174, which is invalid:

expected dependent Bugzilla bug 1934557 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1934863 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miabbott · 2021-03-16T15:29:13Z

expected dependent Bugzilla bug 1934863 to target a release in 4.8.0, but it targets "4.7.z" instead

This doesn't make sense to me; the BZ is for a fix to part of RHCOS in 4.7, it should target 4.7.z

The same fix landed in RHCOS 4.8 as part of https://bugzilla.redhat.com/show_bug.cgi?id=1934174

jlebon · 2021-03-16T15:37:15Z

I've verified that the x86_64 RHCOS version here fixes https://bugzilla.redhat.com/show_bug.cgi?id=1935174.

/lgtm

miabbott · 2021-03-16T15:58:10Z

/test e2e-aws

openshift-bot · 2021-03-16T17:51:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-16T18:03:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-16T19:07:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-16T20:00:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-16T20:52:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-16T21:57:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T02:30:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T02:43:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T03:22:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T03:35:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T03:48:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T04:27:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T05:19:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T06:37:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T08:08:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T08:34:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T09:39:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T10:32:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T10:57:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T11:10:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T12:01:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T12:14:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-17T12:53:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

With 4.6 bundles, /dev/vda4 was automatically extended at startup to fill unused disk space. This no longer happens in 4.7, possibly until openshift/installer#4746 is fixed. This makes the xfs_growfs call in crc ineffective, as /dev/vda4 still has its initial size. This commit makes crc grow the partition itself until this bug is fixed. This fixes crc-org#2104

miabbott · 2021-03-17T13:30:42Z

e2e-openstack-ipi appears to be permafailing well before this PR was introduced

e2e-metal-assisted also permafailing before this PR was introduced. Filed https://bugzilla.redhat.com/show_bug.cgi?id=1939560

e2e-kubevirt also permafailing before this PR was introduced.

openshift-bot · 2021-03-17T13:59:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

With 4.6 bundles, /dev/vda4 was automatically extended at startup to fill unused disk space. This no longer happens in 4.7, possibly until openshift/installer#4746 is fixed. This makes the xfs_growfs call in crc ineffective, as /dev/vda4 still has its initial size. This commit makes crc grow the partition itself until this bug is fixed. This fixes crc-org#2104

staebler · 2021-03-17T14:01:31Z

e2e-openstack-ipi appears to be permafailing well before this PR was introduced

e2e-metal-assisted also permafailing before this PR was introduced. Filed https://bugzilla.redhat.com/show_bug.cgi?id=1939560

e2e-kubevirt also permafailing before this PR was introduced.

Yes, those should not be required jobs. They were introduced as required by a release bug.

/override ci/prow/e2e-openstack-ipi
/override ci/prow/e2e-metal-assisted
/override ci/prow/e2e-kubevirt

openshift-ci-robot · 2021-03-17T14:02:33Z

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-kubevirt, ci/prow/e2e-metal-assisted, ci/prow/e2e-openstack-ipi

Details

In response to this:

e2e-openstack-ipi appears to be permafailing well before this PR was introduced

e2e-metal-assisted also permafailing before this PR was introduced. Filed https://bugzilla.redhat.com/show_bug.cgi?id=1939560

e2e-kubevirt also permafailing before this PR was introduced.

Yes, those should not be required jobs. They were introduced as required by a release bug.

/override ci/prow/e2e-openstack-ipi
/override ci/prow/e2e-metal-assisted
/override ci/prow/e2e-kubevirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jlebon · 2021-03-17T14:07:17Z

/hold

Discussing with @mike-nguyen, who was able to also verify the "rootfs too small" bug is fixed when testing RHCOS directly, but not when using the installer directly.

openshift-ci · 2021-03-17T16:32:13Z

@miabbott: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-metal-assisted	`6792104`	link	`/test e2e-metal-assisted`
ci/prow/e2e-kubevirt	`6792104`	link	`/test e2e-kubevirt`
ci/prow/e2e-openstack-ipi	`6792104`	link	`/test e2e-openstack-ipi`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

With 4.6 bundles, /dev/vda4 was automatically extended at startup to fill unused disk space. This no longer happens in 4.7, possibly until openshift/installer#4746 is fixed. This makes the xfs_growfs call in crc ineffective, as /dev/vda4 still has its initial size. This commit makes crc grow the partition itself until this bug is fixed. This fixes #2104

lucab · 2021-03-19T16:27:25Z

@miabbott @jlebon @mike-nguyen while further validation for the original request is ongoing, can you please refresh the artifacts to something at least as recent as RHCOS 47.83.202103181343? Full details in https://bugzilla.redhat.com/show_bug.cgi?id=1935174#c4.

miabbott · 2021-03-23T13:07:28Z

Oops, I forgot I had this open. I started another, more up-to-date PR over at #4778

Bug 1935174: bump RHCOS boot image for LUKS fixes

6792104

This bumps the RHCOS boot images to address the LUKS problem described in RHBZ#1934863

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 12, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 12, 2021

openshift-ci-robot requested review from jhixson74 and jstuever March 12, 2021 14:16

staebler reviewed Mar 12, 2021

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021

cfergeau mentioned this pull request Mar 16, 2021

Using the --disk-size parameter for crc start does not extend the /sysroot in crc VM [BUG] crc-org/crc#2104

Closed

cfergeau mentioned this pull request Mar 16, 2021

Fix disk resize with 4.7 bundles crc-org/crc#2111

Merged

openshift-ci-robot assigned jlebon Mar 16, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2021

miabbott closed this Mar 23, 2021

Conversation

miabbott commented Mar 12, 2021

Uh oh!

openshift-ci-robot commented Mar 12, 2021

Uh oh!

miabbott commented Mar 12, 2021

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Mar 12, 2021

Uh oh!

miabbott commented Mar 15, 2021

Uh oh!

miabbott commented Mar 16, 2021

Uh oh!

miabbott commented Mar 16, 2021

Uh oh!

miabbott commented Mar 16, 2021

Uh oh!

openshift-ci-robot commented Mar 16, 2021

Uh oh!

miabbott commented Mar 16, 2021

Uh oh!

jlebon commented Mar 16, 2021

Uh oh!

miabbott commented Mar 16, 2021

Uh oh!

openshift-bot commented Mar 16, 2021

Uh oh!

openshift-bot commented Mar 16, 2021

Uh oh!

openshift-bot commented Mar 16, 2021

Uh oh!

openshift-bot commented Mar 16, 2021

Uh oh!

openshift-bot commented Mar 16, 2021

Uh oh!

openshift-bot commented Mar 16, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

miabbott commented Mar 17, 2021

Uh oh!

openshift-bot commented Mar 17, 2021

Uh oh!

staebler commented Mar 17, 2021

Uh oh!