Add SR-IOV notes specific to Kuryr#4957
Conversation
|
/lgtm |
|
/cc @maxwelldb FYI |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/lgtm |
|
Can we perhaps combine with #4958? Both seem to address the same issue of documenting the deployment of SR-IOV capable nodes on networks with port security disabled. |
|
@dulek @iamemilio Would you be more comfortable with including this in the 4.8 downstream docs, or should it be kept to the known issues in the 4.8 RNs? Impacts: openshift/openshift-docs#32876 |
|
@maxwelldb: IMO it can go into downstream 4.8 docs, sure. |
There are some special considerations regarding SR-IOV and Kuryr in 4.8 and this commit makes sure to list them.
|
New changes are detected. LGTM label has been removed. |
| openstack port set --enable-port-security --security-group <infrastructure_ID>-<node_role> <main_port_id> | ||
| ``` | ||
|
|
||
| Those Kuryr specifics will be fixed in the future OpenShift versions. |
There was a problem hiding this comment.
Is there a BZ to track the limitation? If not, could you please create one (and explicitly mentions reverting this PR) and reference it here?
We will also need a different BZ to include this documentation patch in the release-4.8 branch.
There was a problem hiding this comment.
There's https://bugzilla.redhat.com/show_bug.cgi?id=1964540, I added a note linking this patch there.
|
True, this might not be necessary anymore. |
5 participants
There are some special considerations regarding SR-IOV and Kuryr in 4.8
and this commit makes sure to list them.