Skip to content

[ShiftStack] SR-IOV compute machines for IPI installations#32876

Merged
maxwelldb merged 1 commit intoopenshift:masterfrom
maxwelldb:osp-sr-iov-ipi-osdocs2063
Jun 30, 2021
Merged

[ShiftStack] SR-IOV compute machines for IPI installations#32876
maxwelldb merged 1 commit intoopenshift:masterfrom
maxwelldb:osp-sr-iov-ipi-osdocs2063

Conversation

@maxwelldb
Copy link
Copy Markdown
Contributor

@maxwelldb maxwelldb commented May 26, 2021 •
edited
Loading

@maxwelldb maxwelldb added this to the Future Release milestone May 26, 2021
@maxwelldb maxwelldb self-assigned this May 26, 2021
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 26, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented May 26, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: a6b2028

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60dcb8c6e94a2700078d3cc2

😎 Browse the preview: https://deploy-preview-32876--osdocs.netlify.app

@maxwelldb maxwelldb force-pushed the osp-sr-iov-ipi-osdocs2063 branch 2 times, most recently from 18e465c to 909017d Compare May 26, 2021 18:23
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented May 26, 2021

FYI @iamemilio, though this is nowhere near in order yet.

@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2021
@maxwelldb maxwelldb force-pushed the osp-sr-iov-ipi-osdocs2063 branch 3 times, most recently from a1f22f2 to 05e7285 Compare June 4, 2021 18:02
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 4, 2021

@iamemilio This is starting to look like a draft. See https://deploy-preview-32876--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-installer-sr-iov.html#installing-openstack-installer-sr-iov if you want to start reviewing.

@maxwelldb maxwelldb requested a review from iamemilio June 7, 2021 16:57
@iamemilio
Copy link
Copy Markdown

iamemilio commented Jun 8, 2021 •
edited
Loading

overall lgtm, could you include a subsection about when port security is disabled on networks in the add-an-sriov-compute-machine-set link? This was a request from QE

@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 11, 2021

@iamemilio Will do.

@maxwelldb maxwelldb force-pushed the osp-sr-iov-ipi-osdocs2063 branch from 5db7e8c to af3c5d0 Compare June 14, 2021 17:19
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 14, 2021

Does af3c5d0 get what what you're looking for? @iamemilio

@iamemilio
Copy link
Copy Markdown

iamemilio commented Jun 14, 2021 •
edited
Loading

LGTM, Thanks Max

@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 14, 2021

What I believe the QE journey should be:

  1. https://deploy-preview-32876--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-installer-sr-iov.html

  2. At the end of that assembly, complete all relevant items under "To complete SR-IOV configuration for your cluster".

@maxwelldb maxwelldb mentioned this pull request Jun 14, 2021
Closed
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 15, 2021

FYI @dulek that 1c0e3c4 attempts to add what is proposed in openshift/installer#4957. LMK what you think.

@maxwelldb maxwelldb requested a review from dulek June 15, 2021 21:23
@dulek
Copy link
Copy Markdown
Contributor

dulek commented Jun 16, 2021

Looks good to me from perspective of Kuryr remarks, thanks!

@maxwelldb maxwelldb requested a review from itzikb-redhat June 18, 2021 19:04
maxwelldb
maxwelldb commented Jun 20, 2021
View reviewed changes
Comment thread modules/installation-osp-creating-sr-iov-compute-machine-set.adoc Outdated
Copy link
Copy Markdown
Contributor Author

@maxwelldb maxwelldb Jun 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module is unused right now.

Copy link
Copy Markdown
Contributor Author

@maxwelldb maxwelldb Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

maxwelldb
maxwelldb commented Jun 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing fix

Comment thread modules/machineset-yaml-osp-sr-iov-port-security.adoc Outdated
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 23, 2021

@itzikb-redhat Any news on this?

@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 23, 2021

TODO: Add this assembly to #33856

@itzikb-redhat
Copy link
Copy Markdown

itzikb-redhat commented Jun 24, 2021

It's OK from my side, I would like @dulek and Aaron to take a look

@maxwelldb maxwelldb requested a review from atyronesmith June 24, 2021 13:32
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 24, 2021

Review requests added for @atyronesmith and @dulek.

dulek
dulek approved these changes Jun 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dulek dulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kuryr bits look good to me.

atyronesmith
atyronesmith reviewed Jun 24, 2021
View reviewed changes
Comment thread modules/machineset-yaml-osp-sr-iov.adoc Outdated
Copy link
Copy Markdown

@atyronesmith atyronesmith Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware that device role tagging support had been included. Awesome ;).

atyronesmith
atyronesmith approved these changes Jun 24, 2021
View reviewed changes
Copy link
Copy Markdown

@atyronesmith atyronesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 25, 2021

Thanks!

@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 29, 2021

@itzikb-redhat Any comments or questions?

@itzikb-redhat
Copy link
Copy Markdown

itzikb-redhat commented Jun 30, 2021

@maxwelldb no

@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 30, 2021

@itzikb-redhat TY. Can you note that in https://issues.redhat.com/projects/OSDOCS/issues/OSDOCS-2063?

@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 30, 2021

@itzikb-redhat Thank you!

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 30, 2021
mikemckiernan
mikemckiernan reviewed Jun 30, 2021
View reviewed changes
Comment thread _topic_map.yml Outdated
mikemckiernan
mikemckiernan reviewed Jun 30, 2021
View reviewed changes
Comment thread modules/machineset-yaml-osp-sr-iov-port-security.adoc Outdated
mikemckiernan
mikemckiernan reviewed Jun 30, 2021
View reviewed changes
Comment thread modules/machineset-yaml-osp-sr-iov.adoc Outdated
mikemckiernan
mikemckiernan approved these changes Jun 30, 2021
View reviewed changes
Copy link
Copy Markdown

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mikemckiernan mikemckiernan added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 30, 2021
maxwelldb
maxwelldb commented Jun 30, 2021
View reviewed changes
Comment thread modules/machineset-yaml-osp-sr-iov-port-security.adoc Outdated
@maxwelldb maxwelldb force-pushed the osp-sr-iov-ipi-osdocs2063 branch from 8c7311c to a6b2028 Compare June 30, 2021 18:32
@maxwelldb maxwelldb merged commit b665105 into openshift:master Jun 30, 2021
@maxwelldb maxwelldb deleted the osp-sr-iov-ipi-osdocs2063 branch June 30, 2021 18:36
@maxwelldb
Copy link
Copy Markdown
Contributor Author

maxwelldb commented Jun 30, 2021

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 30, 2021

@maxwelldb: new pull request created: #34174

Details

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@itzikb-redhat itzikb-redhat Awaiting requested review from itzikb-redhat

3 more reviewers

@dulek dulek dulek approved these changes

@atyronesmith atyronesmith atyronesmith approved these changes

@mikemckiernan mikemckiernan mikemckiernan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maxwelldb maxwelldb

Labels

branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.8 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@maxwelldb @iamemilio @dulek @itzikb-redhat @openshift-cherrypick-robot @atyronesmith @mikemckiernan @vikram-redhat