Skip to content

Bug 1946079: baremetal: pass IP_OPTIONS to os downloader#4989

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
honza:ip-options-bootstrap
Jun 12, 2021
Merged

Bug 1946079: baremetal: pass IP_OPTIONS to os downloader#4989
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
honza:ip-options-bootstrap

Conversation

@honza
Copy link
Copy Markdown
Member

@honza honza commented Jun 11, 2021

The downloader needs to modify some kernel arguments of the OS image based on the network stack.

cc @asalkeld @sadasu

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 11, 2021

@honza: This pull request references Bugzilla bug 1946079, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @omichaeli

Details

In response to this:

Bug 1946079: baremetal: pass IP_OPTIONS to os downloader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 11, 2021
hardys
hardys reviewed Jun 11, 2021
View reviewed changes
Comment thread data/data/bootstrap/baremetal/files/usr/local/bin/startironic.sh.template Outdated
@honza
baremetal: pass IP_OPTIONS to os downloader
0f9938e 
The downloader needs to modify some kernel arguments of the OS image
based on the network stack.
@honza honza force-pushed the ip-options-bootstrap branch from 6c9618d to 0f9938e Compare June 11, 2021 12:28
@hardys
Copy link
Copy Markdown

hardys commented Jun 11, 2021

This version lgtm, but we need openshift/ironic-rhcos-downloader#43 to merge before this will have any effect

@hardys
Copy link
Copy Markdown

hardys commented Jun 11, 2021

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2021
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 11, 2021

/test e2e-aws-upgrade

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 11, 2021

/test e2e-ovirt

1 similar comment
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 11, 2021

/test e2e-ovirt

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 11, 2021

/test e2e-openstack

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 11, 2021

/retest

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 11, 2021

/test e2e-ovirt

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 11, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 11, 2021

/test e2e-openstack

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 11, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 12, 2021

@honza: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 0f9938e link /test e2e-openstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4c0c295 into openshift:master Jun 12, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 12, 2021

@honza: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1946079 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1946079: baremetal: pass IP_OPTIONS to os downloader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot mentioned this pull request Jun 12, 2021
Merged
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 17, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 17, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 17, 2021

@sadasu: new pull request created: #5013

Details

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omichaeli omichaeli Awaiting requested review from omichaeli

@dhellmann dhellmann Awaiting requested review from dhellmann

@russellb russellb Awaiting requested review from russellb

1 more reviewer

@hardys hardys hardys left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sadasu sadasu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@honza @hardys @sadasu @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot