Skip to content

[release-4.7] Bug 1973367: baremetal: pass IP_OPTIONS to os downloader#5013

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.7from
openshift-cherrypick-robot:cherry-pick-4989-to-release-4.7
Jan 15, 2022
Merged

[release-4.7] Bug 1973367: baremetal: pass IP_OPTIONS to os downloader#5013
openshift-merge-robot merged 1 commit intoopenshift:release-4.7from
openshift-cherrypick-robot:cherry-pick-4989-to-release-4.7

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 17, 2021

This is an automated cherry-pick of #4989

/assign sadasu

@honza
baremetal: pass IP_OPTIONS to os downloader
2ccbb77 
The downloader needs to modify some kernel arguments of the OS image
based on the network stack.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 17, 2021
Merged
@openshift-ci openshift-ci Bot requested review from celebdor and stbenjam June 17, 2021 17:03
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 17, 2021

@openshift-cherrypick-robot: Bugzilla bug 1946079 has been cloned as Bugzilla bug 1973367. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1973367: baremetal: pass IP_OPTIONS to os downloader

Details

In response to this:

[release-4.7] Bug 1946079: baremetal: pass IP_OPTIONS to os downloader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.7] Bug 1946079: baremetal: pass IP_OPTIONS to os downloader [release-4.7] Bug 1973367: baremetal: pass IP_OPTIONS to os downloader Jun 17, 2021
@openshift-ci openshift-ci Bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jun 17, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 17, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1973367, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1946079 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1946079 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @omichaeli

Details

In response to this:

[release-4.7] Bug 1973367: baremetal: pass IP_OPTIONS to os downloader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 17, 2021
@openshift-ci openshift-ci Bot requested a review from omichaeli June 17, 2021 17:03
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 17, 2021

/hold
waiting for the dual-stack failures on 4.8 to be resolved first.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2021
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 28, 2021

/retest

2 similar comments
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 29, 2021

/retest

@asalkeld
Copy link
Copy Markdown
Contributor

asalkeld commented Jun 30, 2021

/retest

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jul 6, 2021

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2021
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jul 6, 2021

/retest

1 similar comment
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jul 6, 2021

/retest

kirankt
kirankt approved these changes Jul 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kirankt kirankt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2021
@hardys
Copy link
Copy Markdown

hardys commented Jul 7, 2021 •
edited
Loading

/retest

The test failure is real - please check the logs:

2021-07-06 17:59:32 panic: template: startironic.sh:96:6: executing "startironic.sh" at <.UseIPv6ForNodeIP>: can't evaluate field UseIPv6ForNodeIP in type *bootstrap.bootstrapTemplateData

That data was added via #4756 so we'll either need to backport that, or partially backport to add the missing TemplateData

/cc @celebdor @yboaron - do you happen to know if we're OK to backport all of #4756 ?

@yboaron
Copy link
Copy Markdown
Contributor

yboaron commented Jul 7, 2021

/retest

The test failure is real - please check the logs:

2021-07-06 17:59:32 panic: template: startironic.sh:96:6: executing "startironic.sh" at <.UseIPv6ForNodeIP>: can't evaluate field UseIPv6ForNodeIP in type *bootstrap.bootstrapTemplateData

That data was added via #4756 so we'll either need to backport that, or partially backport to add the missing TemplateData

/cc @celebdor @yboaron - do you happen to know if we're OK to backport all of #4756 ?

I'm not sure if we want to change kubelet's template for bootstrap for 4.7, but I assume that adding 'UseIPv6ForNodeIP' at (pkg/asset/ignition/bootstrap/common.go) can't harm.

@hardys
Copy link
Copy Markdown

hardys commented Jul 7, 2021

/retest

The test failure is real - please check the logs:

2021-07-06 17:59:32 panic: template: startironic.sh:96:6: executing "startironic.sh" at <.UseIPv6ForNodeIP>: can't evaluate field UseIPv6ForNodeIP in type *bootstrap.bootstrapTemplateData

That data was added via #4756 so we'll either need to backport that, or partially backport to add the missing TemplateData
/cc @celebdor @yboaron - do you happen to know if we're OK to backport all of #4756 ?

I'm not sure if we want to change kubelet's template for bootstrap for 4.7, but I assume that adding 'UseIPv6ForNodeIP' at (pkg/asset/ignition/bootstrap/common.go) can't harm.

Yeah adding the template variable seems fine, I just wasn't sure if we also want the associated kubelet config change backported

@hardys
Copy link
Copy Markdown

hardys commented Jul 8, 2021

#4756 refers to openshift/cluster-kube-apiserver-operator#1042 (which is a release-4.7 backport) so I'm thinking we do want to backport #4756

Added a question on https://bugzilla.redhat.com/show_bug.cgi?id=1931974 to hopefully confirm that

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jul 8, 2021

Yeah adding the template variable seems fine, I just wasn't sure if we also want the associated kubelet config change backported

Just adding "UseIPv6ForNodeIP" to bootstrapTemplateData will not ensure that it has the correct value. I would prefer we backport #4756 before we proceed with the current backport.

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jul 9, 2021

Need #5067 to merge for the e2e-metal-ipi-ovn-ipv6 CI to pass.

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jul 28, 2021

/label platform/baremetal

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

23 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jan 11, 2022

/skip e2e-crc

@kirankt
Copy link
Copy Markdown
Contributor

kirankt commented Jan 11, 2022

/skip

@vvoronkov
Copy link
Copy Markdown

vvoronkov commented Jan 15, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit b406013 into openshift:release-4.7 Jan 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 15, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1973367 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.7] Bug 1973367: baremetal: pass IP_OPTIONS to os downloader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@stbenjam stbenjam Awaiting requested review from stbenjam

@omichaeli omichaeli Awaiting requested review from omichaeli

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

1 more reviewer

@kirankt kirankt kirankt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sadasu sadasu

@kirankt kirankt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.