machines: Extract root disk sizes to constants#5169
machines: Extract root disk sizes to constants#5169openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
/lgtm |
openshift-ci
Bot
added
the
needs-rebase
|
@cgwalters Sorry that this got lost. Would you mind rebasing this when you get a chance? |
openshift-ci
Bot
added
the
approved
I was looking at this issue: openshift/openshift-docs#35793 Which then led me to wonder exactly what the defaults are per platform for disk sizes. And then I stumbled into this 120 vs 128 thing that as best I can tell from the git history is mostly an accident. If someone happens to know differently (e.g. can/should we unify on 120 or 128?) then that'd be good. In the meantime, an additional benefit here is that if one does e.g. `git grep -i volume.*size` these constants will turn up. It took me a little while to figure out how to backtrack from the Terraform code to this. (The lines here only contained `Size` which is too generic to grep)
cgwalters
force-pushed
the
const-disk-sizes
branch
from
494afcf to
1cfe8b6
Compare
openshift-ci
Bot
removed
lgtm
|
On Fri, Dec 3, 2021, at 3:36 PM, Matthew Staebler wrote:
@cgwalters <https://github.com/cgwalters> Sorry that this got lost.
Would you mind rebasing this when you get a chance?
Sure, done 🏄 Was just a minor conflict with
#5301
|
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 participants
I was looking at this issue:
openshift/openshift-docs#35793
Which then led me to wonder exactly what the defaults are per
platform for disk sizes.
And then I stumbled into this 120 vs 128 thing that as best
I can tell from the git history is mostly an accident. If someone
happens to know differently (e.g. can/should we unify on 120 or 128?)
then that'd be good.
In the meantime, an additional benefit here is that if one does
e.g.
git grep -i volume.*sizethese constants will turn up.It took me a little while to figure out how to backtrack from
the Terraform code to this. (The lines here only contained
Sizewhich is too generic to grep)