Skip to content

Remove kubevirt platform#5301

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
nirarg:remove-kubevirt-platform
Oct 20, 2021
Merged

Remove kubevirt platform#5301
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
nirarg:remove-kubevirt-platform

Conversation

@nirarg
Copy link
Copy Markdown
Contributor

@nirarg nirarg commented Oct 18, 2021

This PR is done as part of the decision to stop support kubevirt platform in Openshift Installer

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2021
@openshift-ci openshift-ci Bot requested review from bardielle and chenyosef October 18, 2021 09:57
@nirarg
Copy link
Copy Markdown
Contributor Author

nirarg commented Oct 18, 2021

/retest-required

@nirarg
Copy link
Copy Markdown
Contributor Author

nirarg commented Oct 19, 2021

/test e2e-aws

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2021
@nirarg nirarg force-pushed the remove-kubevirt-platform branch from 345db73 to 4eab87e Compare October 19, 2021 06:33
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2021
@nirarg
Copy link
Copy Markdown
Contributor Author

nirarg commented Oct 19, 2021

/test e2e-aws

@nirarg nirarg force-pushed the remove-kubevirt-platform branch 2 times, most recently from ed0d63c to d267c7e Compare October 19, 2021 11:47
@nirarg nirarg changed the title [WIP] Remove kubevirt platform Remove kubevirt platform Oct 19, 2021
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2021
staebler
staebler reviewed Oct 19, 2021
View reviewed changes
Comment thread data/data/manifests/openshift/cloud-creds-secret.yaml.template Outdated
Copy link
Copy Markdown
Contributor

@staebler staebler Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-{{- end}}
{{- end}}

Copy link
Copy Markdown
Contributor Author

@nirarg nirarg Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

Comment thread go.mod Outdated
Copy link
Copy Markdown
Contributor

@staebler staebler Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something that needs to happen for this PR, but we should do something about this pin since we no longer have the kubevirt.io dependencies.

Copy link
Copy Markdown
Contributor Author

@nirarg nirarg Oct 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, will change this in another PR

Copy link
Copy Markdown
Contributor

@staebler staebler Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5324

@nirarg nirarg force-pushed the remove-kubevirt-platform branch from d267c7e to a13695a Compare October 19, 2021 17:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 19, 2021 •
edited
Loading

@nirarg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt a13695a link false /test e2e-libvirt
ci/prow/e2e-aws-workers-rhel7 a13695a link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-workers-rhel8 a13695a link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-fips a13695a link false /test e2e-aws-fips
ci/prow/e2e-metal-ipi-ovn-ipv6 a13695a link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-crc a13695a link false /test e2e-crc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

staebler
staebler approved these changes Oct 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@staebler staebler mentioned this pull request Oct 20, 2021
Closed
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 68d9ab6 into openshift:master Oct 20, 2021
@aelbarkani
Copy link
Copy Markdown

aelbarkani commented Nov 4, 2021 •
edited
Loading

Hi! Is there any replacement for this feature in order to deploy an OpenShift cluster inside an OpenShift cluster :) ?

@aelbarkani
Copy link
Copy Markdown

aelbarkani commented Nov 5, 2021

cc @nirarg @staebler

This was referenced Nov 5, 2021
Closed
Closed
@nirarg
Copy link
Copy Markdown
Contributor Author

nirarg commented Nov 7, 2021 •
edited
Loading

Hi! Is there any replacement for this feature in order to deploy an OpenShift cluster inside an OpenShift cluster :) ?

Hi @aelbarkani , currently there is work to add this ability (KubeVirt platform) to Hypershift project (https://github.com/openshift/hypershift/)

@aelbarkani
Copy link
Copy Markdown

aelbarkani commented Nov 7, 2021

Awesome, thanks @nirarg !

@cgwalters cgwalters mentioned this pull request Dec 4, 2021
Merged
@mbarnes mbarnes mentioned this pull request Jan 25, 2022
Merged
jewzaam added a commit to jewzaam/installer-aro that referenced this pull request Jan 25, 2022
@jewzaam
Merge pull request #10 from mbarnes/remove-kubevirt-platform
68650c1 
Merge pull request openshift#5301 from nirarg/remove-kubevirt-platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bardielle bardielle Awaiting requested review from bardielle

@chenyosef chenyosef Awaiting requested review from chenyosef

1 more reviewer

@staebler staebler staebler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@staebler staebler

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nirarg @openshift-bot @aelbarkani @staebler @openshift-merge-robot