Skip to content

LAB/cluster-bot: change default AWS IPI to instance=m6i and EBS=gp3#5328

Closed
mtulio wants to merge 2 commits intoopenshift:masterfrom
mtulio:lab-aws-m6i-gp3
Closed

LAB/cluster-bot: change default AWS IPI to instance=m6i and EBS=gp3#5328
mtulio wants to merge 2 commits intoopenshift:masterfrom
mtulio:lab-aws-m6i-gp3

Conversation

@mtulio
Copy link
Copy Markdown
Contributor

@mtulio mtulio commented Oct 26, 2021 •
edited
Loading

LAB Only: to be used in cluster-bot as it seems to not support specifying specific GH user's PR (eg mtulio#6)

Changes to increase control plane performance just changing to the most recent AWS instance (m6i) and volume type (gp3).

Joint PRs for #5327 and #5239

mtulio added 2 commits October 25, 2021 23:54
@mtulio
refact/aws-ebs-gp3: changing default EBS type on masters to gp3.
a9153cc 
This is WIP validation to support gp3 as default on IPI, due the benefits compared to gp2.

Overview of improvements of gp3 compared to gp2:
- The baseline IOPS was increased to 3,000 : gp2 volumes is allowed to burst up to 3,000 IOPS with a baseline of 1:3 GiB:IOPS, so volumes with low capacity will have a low baseline and can be impacted with long periods of I/O
- Now it is allowed to increase the throughput regardless of capacity with a baseline of 125 MiB/s (extra fee is charged per MiB/s provisioned above the baseline)
- Now it is allowed to increase the IOPS regardless of capacity with a baseline of 3,000 IOPS (extra fee is charged per IOPS provisioned above the baseline)
- Cheaper : The cost of gp3 is 20% lower than gp2 in a standard baseline

More details on the study case on SPLAT-253.
@mtulio
lab/dont-merge: joint PRs (5239 + 5327) to be tested on cluster bot
b4407f4
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 26, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jstuever after the PR has been reviewed.
You can assign the PR to them by writing /assign @jstuever in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Oct 26, 2021

The cluster created by cluster-bot for this PR (confirming m6i and gp3):

NAME                                                PHASE     TYPE         REGION      ZONE         AGE
ci-ln-48vbxkk-76ef8-j6rld-master-0                  Running   m6i.xlarge   us-east-1   us-east-1c   20m
ci-ln-48vbxkk-76ef8-j6rld-master-1                  Running   m6i.xlarge   us-east-1   us-east-1f   20m
ci-ln-48vbxkk-76ef8-j6rld-master-2                  Running   m6i.xlarge   us-east-1   us-east-1c   20m
ci-ln-48vbxkk-76ef8-j6rld-worker-us-east-1c-7p76b   Running   m5.xlarge    us-east-1   us-east-1c   18m
ci-ln-48vbxkk-76ef8-j6rld-worker-us-east-1c-vg7lt   Running   m5.xlarge    us-east-1   us-east-1c   18m
ci-ln-48vbxkk-76ef8-j6rld-worker-us-east-1f-c9cnp   Running   m5.xlarge    us-east-1   us-east-1f   18m

$ oc get machines -n openshift-machine-api ci-ln-48vbxkk-76ef8-j6rld-master-0 -o json |jq -r '.spec.providerSpec.value | (.instanceType , .placement.region, .blockDevices) '
m6i.xlarge
us-east-1
[
  {
    "ebs": {
      "encrypted": true,
      "iops": 0,
      "kmsKey": {
        "arn": ""
      },
      "volumeSize": 120,
      "volumeType": "gp3"
    }
  }
]

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Oct 26, 2021

cc @hexfusion @rsevilla87

mtulio added a commit to mtulio/terraform-provider-aws that referenced this pull request Nov 10, 2021
@mtulio
feat/ebs-gp3: add basic support to gp3 volumes
b93a5eb 
Add basic gp3 validation on provider to support to change the default
control plane volumes on AWS IPI.

The basic support means that this change will only make the terraform
validate gp3 volumes. The full support should allow to add parameters
like volume IOPS and throughput, that is completely new in General Pourpose
volumes (introduced in gp3) - and not covereed here as it need more changes
on this openshift's fork.

References:
- openshift/installer#5239
- openshift/installer#5328
@mtulio mtulio mentioned this pull request Nov 10, 2021
Closed
@mtulio mtulio mentioned this pull request Nov 10, 2021
Closed
mtulio added a commit to mtulio/terraform-provider-aws that referenced this pull request Nov 11, 2021
@mtulio
feat/ebs-gp3: add basic support to gp3 volumes
fa3d986 
Add basic gp3 validation on the provider to support changing the default
control-plane volumes on AWS IPI.

The basic support means that this change will only make the terraform
validate gp3 volumes. The full support should allow adding parameters
like volume IOPS and throughput, which is completely new in General Purpose
volumes (introduced in gp3) - and not covered here as it needs more changes
on this openshift's fork.

References:
- openshift/installer#5239
- openshift/installer#5328
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 1, 2021

@mtulio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade b4407f4 link true /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Dec 15, 2021

We don't need more this PR to be used in cluster-bot, the #5373 was merged

@mtulio mtulio closed this Dec 15, 2021
@mtulio mtulio deleted the lab-aws-m6i-gp3 branch December 15, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mtulio