Skip to content

AWS: Remove unused Instance Class Function#5335

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
patrickdillon:rm-instance-class
Dec 16, 2021
Merged

AWS: Remove unused Instance Class Function#5335
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
patrickdillon:rm-instance-class

Conversation

@patrickdillon
Copy link
Copy Markdown
Contributor

@patrickdillon patrickdillon commented Oct 27, 2021

After switching the bootstrap to use the same instance type as masters, the defaults.InstanceClass is no longer used so this
commit removes it.

/hold
Depends on #5334

@patrickdillon
Bug 2016955: Set AWS Bootstrap Type == Master
6fc25a6 
This commit sets the boostrap node to use the
same instance type as the control-plane nodes
in order to avoid failures that we have seen
when the hard-coded instance type of m5 is
unavailable in the zone.
@patrickdillon
AWS: Remove unused Instance Class Function
77bc956 
After switching the bootstrap to use the same instance type as
masters, the defaults.InstanceClass is no longer used so this
commit removes it.
@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2021
@openshift-ci openshift-ci Bot requested review from jstuever and rna-afk October 27, 2021 20:16
@patrickdillon patrickdillon mentioned this pull request Oct 27, 2021
Merged
staebler
staebler approved these changes Oct 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@rna-afk
Copy link
Copy Markdown
Contributor

rna-afk commented Nov 10, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 1, 2021

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel7 77bc956 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-workers-rhel8 77bc956 link false /test e2e-aws-workers-rhel8
ci/prow/okd-e2e-aws-upgrade 77bc956 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-aws-upgrade 77bc956 link true /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Copy Markdown
Contributor Author

patrickdillon commented Dec 16, 2021

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit feaf952 into openshift:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@rna-afk rna-afk Awaiting requested review from rna-afk

1 more reviewer

@staebler staebler staebler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@staebler staebler

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@patrickdillon @rna-afk @openshift-bot @staebler @openshift-merge-robot