Bug 2016955: Set AWS Bootstrap Type == Master by patrickdillon · Pull Request #5334 · openshift/installer

patrickdillon · 2021-10-27T19:45:35Z

This commit sets the boostrap node to use the same instance type as the control-plane nodes
in order to avoid failures that we have seen when the hard-coded instance type of m5 is unavailable in the zone.

Setting the bootstrap instance type equal to the control-plane instance type is the approach we already take on GCP & Azure.

This commit sets the boostrap node to use the same instance type as the control-plane nodes in order to avoid failures that we have seen when the hard-coded instance type of m5 is unavailable in the zone.

openshift-ci · 2021-10-27T19:45:39Z

@patrickdillon: This pull request references Bugzilla bug 2016955, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2016955: Set AWS Bootstrap Type == Master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2021-10-27T19:46:37Z

/bugzilla refresh

openshift-ci · 2021-10-27T19:46:44Z

@patrickdillon: This pull request references Bugzilla bug 2016955, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

staebler

/lgtm

staebler · 2021-10-27T20:01:18Z

 		return nil, errors.New("EBS IOPS must be configured for the io1 root volume")
 	}

-	instanceClass := defaults.InstanceClass(masterConfig.Placement.Region, sources.Architecture)


I think we don't need the InstanceClass function any more. But we can take care of that in a separate PR that doesn't need to be backported.

Ok. Wasn't sure if we wanted to keep it or not. Done in #5335

openshift-ci · 2021-10-27T20:02:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/tfvars/aws/OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

patrickdillon · 2021-10-27T20:04:53Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2021-10-27T20:04:53Z

@patrickdillon: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2021-10-27T20:33:21Z

/cherry-pick cancel

Manually picked #5337

openshift-cherrypick-robot · 2021-10-27T20:33:22Z

@patrickdillon: once the present PR merges, I will cherry-pick it on top of cancel in a new PR and assign it to you.

Details

In response to this:

/cherry-pick cancel

Manually picked #5337

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2021-10-27T20:33:47Z

I will cherry-pick it on top of cancel in a new PR and assign it to you.

Oh, good. Thank you.

openshift-bot · 2021-10-27T20:53:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-27T21:32:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-27T21:58:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-27T23:30:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-27T23:42:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-27T23:55:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-28T00:08:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-28T00:34:09Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-28T00:47:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-28T00:48:23Z

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-workers-rhel8	`6fc25a6`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-workers-rhel7	`6fc25a6`	link	false	`/test e2e-aws-workers-rhel7`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-10-28T01:00:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-28T01:39:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-28T02:05:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-28T02:18:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-28T02:44:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-28T02:55:20Z

@patrickdillon: All pull requests linked via external trackers have merged:

openshift/installer#5334

Bugzilla bug 2016955 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2016955: Set AWS Bootstrap Type == Master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-10-28T02:56:11Z

@patrickdillon: new pull request created: #5339

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-10-28T02:57:53Z

@patrickdillon: cannot checkout cancel: error checking out cancel: exit status 1. output: error: pathspec 'cancel' did not match any file(s) known to git

Details

In response to this:

/cherry-pick cancel

Manually picked #5337

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 2016955: Set AWS Bootstrap Type == Master

6fc25a6

This commit sets the boostrap node to use the same instance type as the control-plane nodes in order to avoid failures that we have seen when the hard-coded instance type of m5 is unavailable in the zone.

openshift-ci Bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 27, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 27, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 27, 2021

openshift-ci Bot requested review from jstuever and rna-afk October 27, 2021 19:47

staebler approved these changes Oct 27, 2021

View reviewed changes

openshift-ci Bot assigned staebler Oct 27, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021

patrickdillon mentioned this pull request Oct 27, 2021

AWS: Remove unused Instance Class Function #5335

Merged

openshift-merge-robot merged commit c3e9ffd into openshift:master Oct 28, 2021

openshift-cherrypick-robot mentioned this pull request Oct 28, 2021

[release-4.9] Bug 2017985: Set AWS Bootstrap Type == Master #5339

Closed

mtulio mentioned this pull request Mar 21, 2022

BZ2065025: AWS Instance - fix references to current type (M6i) openshift/openshift-docs#43558

Merged

Conversation

patrickdillon commented Oct 27, 2021

Uh oh!

openshift-ci Bot commented Oct 27, 2021

Uh oh!

patrickdillon commented Oct 27, 2021

Uh oh!

openshift-ci Bot commented Oct 27, 2021

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

staebler Oct 27, 2021

Choose a reason for hiding this comment

Uh oh!

patrickdillon Oct 27, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Oct 27, 2021

Uh oh!

patrickdillon commented Oct 27, 2021

Uh oh!

openshift-cherrypick-robot commented Oct 27, 2021

Uh oh!

patrickdillon commented Oct 27, 2021

Uh oh!

openshift-cherrypick-robot commented Oct 27, 2021

Uh oh!

patrickdillon commented Oct 27, 2021

Uh oh!

openshift-bot commented Oct 27, 2021

Uh oh!

openshift-bot commented Oct 27, 2021

Uh oh!

openshift-bot commented Oct 27, 2021

Uh oh!

openshift-bot commented Oct 27, 2021

Uh oh!

openshift-bot commented Oct 27, 2021

Uh oh!

openshift-bot commented Oct 27, 2021

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

openshift-ci Bot commented Oct 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

openshift-bot commented Oct 28, 2021

Uh oh!

openshift-ci Bot commented Oct 28, 2021

Uh oh!

openshift-cherrypick-robot commented Oct 28, 2021

Uh oh!

openshift-cherrypick-robot commented Oct 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci Bot commented Oct 28, 2021 •

edited

Loading