Skip to content

BZ2065025: AWS Instance - fix references to current type (M6i)#43558

Merged
ahardin-rh merged 1 commit intoopenshift:mainfrom
mtulio:fix-bz2065025
Apr 18, 2022
Merged

BZ2065025: AWS Instance - fix references to current type (M6i)#43558
ahardin-rh merged 1 commit intoopenshift:mainfrom
mtulio:fix-bz2065025

Conversation

@mtulio
Copy link
Copy Markdown
Contributor

@mtulio mtulio commented Mar 21, 2022 •
edited
Loading

Review references to current instance types on AWS for 4.10.

References:

cc related teams: @staebler @patrickdillon @JoelSpeed @sdodson

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 21, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 456e795
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/625569086689aa0008b7c4f8
😎 Deploy Preview https://deploy-preview-43558--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mtulio
mtulio commented Mar 21, 2022
View reviewed changes
Comment thread modules/installation-supported-aws-machine-types.adoc Outdated
Copy link
Copy Markdown
Contributor Author

@mtulio mtulio Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After openshift/installer#5334 , the current list of bootstrap type is outdated. I believe we need to fix this list too. Let me know wdyt @patrickdillon

@mtulio mtulio mentioned this pull request Mar 21, 2022
Closed
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2022
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2022
@mtulio mtulio force-pushed the fix-bz2065025 branch 2 times, most recently from c6a4071 to 298af1e Compare March 24, 2022 15:17
tmalove
tmalove reviewed Mar 24, 2022
View reviewed changes
Comment thread modules/aws-limits.adoc Outdated
tmalove
tmalove reviewed Mar 24, 2022
View reviewed changes
Comment thread modules/installation-aws-limits.adoc Outdated
mtulio
mtulio commented Mar 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@mtulio mtulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team review

Comment thread modules/aws-limits.adoc Outdated
Comment thread modules/installation-aws-limits.adoc Outdated
@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Mar 24, 2022

@tmalove done

@ahardin-rh ahardin-rh added this to the Next Release milestone Mar 24, 2022
@ahardin-rh ahardin-rh requested a review from yunjiang29 March 24, 2022 17:44
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Mar 24, 2022

@yunjiang29 Can you please provide QE review or point us to the correct contact? Thank you!

yunjiang29
yunjiang29 reviewed Mar 25, 2022
View reviewed changes
Comment thread modules/installation-creating-aws-worker.adoc Outdated
yunjiang29
yunjiang29 reviewed Mar 25, 2022
View reviewed changes
Comment thread modules/installation-creating-aws-control-plane.adoc Outdated
@mtulio mtulio force-pushed the fix-bz2065025 branch 2 times, most recently from 71a303b to 43cef14 Compare March 30, 2022 12:04
@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 30, 2022
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2022
yunjiang29
yunjiang29 reviewed Apr 1, 2022
View reviewed changes
Comment thread modules/installation-creating-aws-control-plane.adoc Outdated
yunjiang29
yunjiang29 reviewed Apr 1, 2022
View reviewed changes
Comment thread modules/installation-creating-aws-worker.adoc Outdated
mtulio
mtulio commented Apr 1, 2022
View reviewed changes
Comment thread modules/installation-creating-aws-worker.adoc Outdated
yunjiang29
yunjiang29 reviewed Apr 12, 2022
View reviewed changes
Comment thread modules/installation-creating-aws-worker.adoc Outdated
@yunjiang29
Copy link
Copy Markdown
Contributor

yunjiang29 commented Apr 13, 2022

@mtulio lgtm, thanks for the updates.

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 18, 2022
@ahardin-rh ahardin-rh merged commit 94abf5d into openshift:main Apr 18, 2022
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Apr 18, 2022

/cherrypick enterprise-4.10

@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Apr 18, 2022

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2022
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 18, 2022

@ahardin-rh: new pull request created: #44641

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2022
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 18, 2022

@ahardin-rh: new pull request created: #44642

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio deleted the fix-bz2065025 branch April 18, 2022 14:17
@mtulio mtulio mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@yunjiang29 yunjiang29 yunjiang29 left review comments

@tmalove tmalove tmalove left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@mtulio @ahardin-rh @yunjiang29 @openshift-cherrypick-robot @tmalove