[release-4.10] Bug 2077411: for vsphere ipi add cluster domain to the uploaded vm configs so that 30-local-dns-prepender can use it by openshift-cherrypick-robot · Pull Request #5827 · openshift/installer

openshift-cherrypick-robot · 2022-04-21T10:21:11Z

This is an automated cherry-pick of #5788

/assign vrutkovs

… 30-local-dns-prepender can use it Due to changes in FCOS 35 /etc/nsswitch.conf, we need to move the name resolution of api-int.<domain> to systemd-resolved. The way we do this is by adding a Domain attribute to /etc/systemd/resolved.conf.d/60-kni.conf. Since we are using a slightly different prepender than the masters and workers the domain is not being discovered automatically. To address this we are adding the domain in data/data/vsphere/bootstrap/main.tf which gets uploaded to the bootstrap instance on creation. 30-local-dns-prepender then downloads this information and adds it to /etc/systemd/resolved.conf.d/60-kni.conf Note that we check for a non-empty domain before writing /etc/systemd/resolved.conf.d/60-kni.conf. Fixes okd-project/okd#1182 Signed-off-by: John Fortin <fortinj66@gmail.com>

openshift-ci · 2022-04-21T10:21:22Z

@openshift-cherrypick-robot: Bugzilla bug 2076880 has been cloned as Bugzilla bug 2077411. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2077411: for vsphere ipi add cluster domain to the uploaded vm configs so that 30-local-dns-prepender can use it

Details

In response to this:

[release-4.10] Bug 2076880: for vsphere ipi add cluster domain to the uploaded vm configs so that 30-local-dns-prepender can use it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-21T10:21:28Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2077411, which is invalid:

expected dependent Bugzilla bug 2076880 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.10] Bug 2077411: for vsphere ipi add cluster domain to the uploaded vm configs so that 30-local-dns-prepender can use it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2022-04-21T10:53:59Z

/approve

kirankt

/lgtm

fortinj66 · 2022-04-21T17:37:05Z

/bugzilla refresh

openshift-ci · 2022-04-21T17:37:09Z

@fortinj66: This pull request references Bugzilla bug 2077411, which is invalid:

expected dependent Bugzilla bug 2076880 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-22T01:00:20Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-22T01:00:25Z

@openshift-bot: This pull request references Bugzilla bug 2077411, which is invalid:

expected dependent Bugzilla bug 2076880 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fortinj66 · 2022-04-22T12:59:10Z

/bugzilla refresh

openshift-ci · 2022-04-22T12:59:21Z

@fortinj66: This pull request references Bugzilla bug 2077411, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.z) matches configured target release for branch (4.10.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2076880 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2076880 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

patrickdillon · 2022-04-23T20:38:10Z

/approve
/label backport-risk-assessed

openshift-ci · 2022-04-23T20:38:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kirankt, patrickdillon, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-04-23T20:45:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

fortinj66 · 2022-04-23T21:24:33Z

/retest-required

openshift-bot · 2022-04-23T22:57:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

patrickdillon · 2022-04-23T23:08:01Z

/retest

openshift-bot · 2022-04-23T23:10:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-24T00:33:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-24T01:45:45Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-24T02:09:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-24T02:36:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-04-24T03:02:09Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-alibaba	`82a95d6`	link	false	`/test e2e-alibaba`
ci/prow/e2e-azurestack	`82a95d6`	link	false	`/test e2e-azurestack`
ci/prow/e2e-azurestack-upi	`82a95d6`	link	false	`/test e2e-azurestack-upi`
ci/prow/okd-e2e-gcp	`82a95d6`	link	false	`/test okd-e2e-gcp`
ci/prow/okd-e2e-vsphere	`82a95d6`	link	false	`/test okd-e2e-vsphere`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-04-24T05:27:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

gpei · 2022-04-24T05:36:09Z

/label cherry-pick-approved

gpei · 2022-04-24T05:36:11Z

/label cherry-pick-approved

openshift-ci · 2022-04-24T05:40:32Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/installer#5827

Bugzilla bug 2077411 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.10] Bug 2077411: for vsphere ipi add cluster domain to the uploaded vm configs so that 30-local-dns-prepender can use it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Apr 21, 2022

Bug 2076880: for vsphere ipi add cluster domain to the uploaded vm configs so that 30-local-dns-prepender can use it #5788

Merged

openshift-ci Bot assigned vrutkovs Apr 21, 2022

openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 21, 2022

openshift-ci Bot requested review from jstuever and kirankt April 21, 2022 10:22

kirankt approved these changes Apr 21, 2022

View reviewed changes

openshift-ci Bot assigned kirankt Apr 21, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2022

openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 22, 2022

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 23, 2022

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2022

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 24, 2022

openshift-merge-robot merged commit 1e29cda into openshift:release-4.10 Apr 24, 2022

This was referenced Aug 29, 2023

[OKD 4.13][vSphere 4.13] IPI Install broken. Bootstrap doesn't clean up due to https://github.com/openshift/installer/pull/6770 okd-project/okd#1715

Closed

SPLAT-823: Zonal GA, single terraform, deprecate legacy platform spec #6770

Merged

Conversation

openshift-cherrypick-robot commented Apr 21, 2022

Uh oh!

openshift-ci Bot commented Apr 21, 2022

Uh oh!

openshift-ci Bot commented Apr 21, 2022

Uh oh!

vrutkovs commented Apr 21, 2022

Uh oh!

kirankt left a comment

Choose a reason for hiding this comment

Uh oh!

fortinj66 commented Apr 21, 2022

Uh oh!

openshift-ci Bot commented Apr 21, 2022

Uh oh!

openshift-bot commented Apr 22, 2022

Uh oh!

openshift-ci Bot commented Apr 22, 2022

Uh oh!

fortinj66 commented Apr 22, 2022

Uh oh!

openshift-ci Bot commented Apr 22, 2022

Uh oh!

patrickdillon commented Apr 23, 2022

Uh oh!

openshift-ci Bot commented Apr 23, 2022

Uh oh!

openshift-bot commented Apr 23, 2022

Uh oh!

fortinj66 commented Apr 23, 2022

Uh oh!

openshift-bot commented Apr 23, 2022

Uh oh!

patrickdillon commented Apr 23, 2022

Uh oh!

openshift-bot commented Apr 23, 2022

Uh oh!

openshift-bot commented Apr 24, 2022

Uh oh!

openshift-bot commented Apr 24, 2022

Uh oh!

openshift-bot commented Apr 24, 2022

Uh oh!

openshift-bot commented Apr 24, 2022

Uh oh!

openshift-ci Bot commented Apr 24, 2022

Uh oh!

openshift-bot commented Apr 24, 2022

Uh oh!

gpei commented Apr 24, 2022

Uh oh!

gpei commented Apr 24, 2022

Uh oh!

openshift-ci Bot commented Apr 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants