SPLAT-823: Zonal GA, single terraform, deprecate legacy platform spec by jcpowermac · Pull Request #6770 · openshift/installer

jcpowermac · 2023-01-12T18:40:30Z

This PR does the following:

Converts existing install-config vsphere platform spec for IPI, UPI and 4.12 Zonal IPI to 4.13 unified non-depreciated platform fields
Replaces the existing non zonal terraform project with zonal as the unified
vsphere-specific fields are now required to be paths
Remove OVA hardware version upgrade within terraform resource ova import (no longer required, OVA is HW15)
Add check for vSphere 7 Update 2 or greater being required in 4.13

Left to do:

Update unit tests
Clean up todo: jcallen: items
make sure TUI functions correctly

openshift-ci · 2023-01-12T18:40:35Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

jcpowermac · 2023-01-17T20:36:21Z

/test e2e-vsphere-upi

jcpowermac · 2023-01-17T20:37:05Z

/test e2e-vsphere-ovn

jcpowermac · 2023-01-17T23:20:26Z

/test e2e-vsphere-upi

jcpowermac · 2023-01-17T23:20:40Z

/test e2e-vsphere-ovn

jcpowermac · 2023-01-18T01:25:59Z

/test e2e-vsphere-ovn
/test e2e-vsphere-upi

jcpowermac · 2023-01-18T12:57:12Z

UPI got past installer, IPI still failed

/test e2e-vsphere-ovn

jcpowermac · 2023-01-20T17:45:12Z

/test e2e-vsphere-ovn

jcpowermac · 2023-01-23T16:50:24Z

/test e2e-vsphere-ovn

jcpowermac · 2023-01-23T18:28:19Z

/test e2e-vsphere-ovn

jcpowermac · 2023-01-23T21:59:14Z

/test e2e-vsphere-zones

jcpowermac · 2023-01-23T21:59:34Z

/test e2e-vsphere-upi

jcpowermac · 2023-01-24T14:41:20Z

/test e2e-vsphere-zones
/test e2e-vsphere-ovn

jcpowermac · 2023-01-24T18:18:44Z

/test e2e-vsphere-zones
/test e2e-vsphere-ovn

jcpowermac · 2023-01-24T21:37:14Z

/test e2e-vsphere-zones

jcpowermac · 2023-01-24T22:48:04Z

Can you take a peak when you have a moment @patrickdillon thanks!

jcpowermac · 2023-02-16T18:37:53Z

e2e-vsphere-ovn install completed, in-tree storage test failures, discussed:
https://redhat-internal.slack.com/archives/CH06KMDRV/p1676571632750069
https://issues.redhat.com/browse/OCPBUGS-7616

jcpowermac · 2023-02-16T18:43:06Z

/test e2e-vsphere-ovn

jcpowermac · 2023-02-16T18:57:49Z

/test e2e-vsphere-zones

jcpowermac · 2023-02-16T20:34:09Z

/test okd-images

rvanderp3 · 2023-02-16T21:54:39Z

/lgtm

openshift-ci-robot · 2023-02-16T22:39:40Z

/retest-required

Remaining retests: 0 against base HEAD 088033f and 2 for PR HEAD a06dfe9 in total

openshift-ci-robot · 2023-02-17T02:39:51Z

/retest-required

Remaining retests: 0 against base HEAD 97be419 and 1 for PR HEAD a06dfe9 in total

openshift-ci-robot · 2023-02-17T05:39:44Z

/retest-required

Remaining retests: 0 against base HEAD 9006c22 and 0 for PR HEAD a06dfe9 in total

openshift-ci-robot · 2023-02-17T08:39:33Z

/hold

Revision a06dfe9 was retested 3 times: holding

rvanderp3 · 2023-02-17T13:21:42Z

/hold cancel
/retest-required

openshift-ci-robot · 2023-02-17T16:11:31Z

/retest-required

Remaining retests: 0 against base HEAD 9006c22 and 2 for PR HEAD a06dfe9 in total

openshift-ci-robot · 2023-02-17T20:11:20Z

/retest-required

Remaining retests: 0 against base HEAD 3067a71 and 1 for PR HEAD a06dfe9 in total

openshift-ci-robot · 2023-02-18T06:11:14Z

/retest-required

Remaining retests: 0 against base HEAD d412809 and 0 for PR HEAD a06dfe9 in total

openshift-ci-robot · 2023-02-18T10:11:24Z

/hold

Revision a06dfe9 was retested 3 times: holding

jcpowermac · 2023-02-20T13:58:35Z

waiting on...
openshift/origin#27736

jcpowermac · 2023-02-20T18:09:26Z

/hold cancel
/retest-required

openshift-ci · 2023-02-20T21:20:55Z

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-workers-rhel8	`a06dfe9`	link	false	`/test e2e-aws-ovn-workers-rhel8`
ci/prow/okd-scos-e2e-aws-upgrade	`a06dfe9`	link	false	`/test okd-scos-e2e-aws-upgrade`
ci/prow/okd-e2e-aws-ovn-upgrade	`a06dfe9`	link	false	`/test okd-e2e-aws-ovn-upgrade`
ci/prow/okd-e2e-aws-ovn	`a06dfe9`	link	false	`/test okd-e2e-aws-ovn`
ci/prow/e2e-vsphere-upi-zones	`a06dfe9`	link	false	`/test e2e-vsphere-upi-zones`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-02-20T21:43:42Z

/retest-required

Remaining retests: 0 against base HEAD d412809 and 2 for PR HEAD a06dfe9 in total

fortinj66 · 2023-08-29T16:39:15Z

This has broken the OKD 4.13 Installer as bootstrap no longer cleans up. See okd-project/okd#1715.

This reverts #5827

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2023

jcpowermac commented Jan 12, 2023

View reviewed changes

Comment thread pkg/types/vsphere/conversion/installconfig.go

jcpowermac commented Jan 12, 2023

View reviewed changes

Comment thread pkg/asset/manifests/vsphere/cloudproviderconfig.go Outdated

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2023

jcpowermac force-pushed the SPLAT-823 branch from bbd0932 to 3c7a168 Compare January 17, 2023 20:32

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2023

jcpowermac force-pushed the SPLAT-823 branch from fbc173b to 34b0271 Compare January 17, 2023 23:19

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2023

jcpowermac commented Jan 18, 2023

View reviewed changes

Comment thread pkg/tfvars/vsphere/vsphere.go Outdated

jcpowermac force-pushed the SPLAT-823 branch from 0c6a160 to 667516c Compare January 19, 2023 13:15

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2023

jcpowermac force-pushed the SPLAT-823 branch from 1d30b85 to b77034f Compare January 23, 2023 16:50

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2023

openshift-ci Bot assigned rvanderp3 Feb 16, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2023

openshift-merge-robot merged commit c8c5d59 into openshift:master Feb 21, 2023

petr-balogh mentioned this pull request Feb 27, 2023

VSphere UPI failing to create cluster - invalid resource pool format red-hat-storage/ocs-ci#7161

Closed

sgaoshang mentioned this pull request Mar 15, 2023

OSDOCS-5192-SPLAT: Added content for SPLAT failure-domain work openshift/openshift-docs#55531

Merged

1 task

fortinj66 mentioned this pull request Aug 29, 2023

[OKD 4.13][vSphere 4.13] IPI Install broken. Bootstrap doesn't clean up due to https://github.com/openshift/installer/pull/6770 okd-project/okd#1715

Closed

vrutkovs mentioned this pull request Aug 29, 2023

OCPBUGS-18304: for vsphere ipi add cluster domain to the uploaded vm configs so that… #7451

Merged

Conversation

jcpowermac commented Jan 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jan 12, 2023

Uh oh!

Uh oh!

Uh oh!

jcpowermac commented Jan 17, 2023

Uh oh!

jcpowermac commented Jan 17, 2023

Uh oh!

jcpowermac commented Jan 17, 2023

Uh oh!

jcpowermac commented Jan 17, 2023

Uh oh!

jcpowermac commented Jan 18, 2023

Uh oh!

jcpowermac commented Jan 18, 2023

Uh oh!

Uh oh!

jcpowermac commented Jan 20, 2023

Uh oh!

jcpowermac commented Jan 23, 2023

Uh oh!

jcpowermac commented Jan 23, 2023

Uh oh!

jcpowermac commented Jan 23, 2023

Uh oh!

jcpowermac commented Jan 23, 2023

Uh oh!

jcpowermac commented Jan 24, 2023

Uh oh!

jcpowermac commented Jan 24, 2023

Uh oh!

jcpowermac commented Jan 24, 2023

Uh oh!

jcpowermac commented Jan 24, 2023

Uh oh!

jcpowermac commented Feb 16, 2023

Uh oh!

jcpowermac commented Feb 16, 2023

Uh oh!

jcpowermac commented Feb 16, 2023

Uh oh!

jcpowermac commented Feb 16, 2023

Uh oh!

rvanderp3 commented Feb 16, 2023

Uh oh!

openshift-ci-robot commented Feb 16, 2023

Uh oh!

openshift-ci-robot commented Feb 17, 2023

Uh oh!

openshift-ci-robot commented Feb 17, 2023

Uh oh!

openshift-ci-robot commented Feb 17, 2023

Uh oh!

rvanderp3 commented Feb 17, 2023

Uh oh!

openshift-ci-robot commented Feb 17, 2023

Uh oh!

openshift-ci-robot commented Feb 17, 2023

Uh oh!

openshift-ci-robot commented Feb 18, 2023

Uh oh!

openshift-ci-robot commented Feb 18, 2023

Uh oh!

jcpowermac commented Feb 20, 2023

Uh oh!

jcpowermac commented Feb 20, 2023

Uh oh!

openshift-ci Bot commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 20, 2023

Uh oh!

fortinj66 commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

jcpowermac commented Jan 12, 2023 •

edited

Loading

openshift-ci Bot commented Feb 20, 2023 •

edited

Loading

fortinj66 commented Aug 29, 2023 •

edited

Loading