Skip to content

Revert "bump(k8s): 1.26"#27736

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
stbenjam:revert-27694-bump-1.26
Feb 20, 2023
Merged

Revert "bump(k8s): 1.26"#27736
openshift-merge-robot merged 1 commit into
openshift:masterfrom
stbenjam:revert-27694-bump-1.26

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented Feb 17, 2023 •
edited
Loading

Reverts #27694 ; tracked by OCPBUGS-7616

#27694 is suspected of breaking all vsphere CI. The process to get this fixed is long since it requires an upstream fix, backport to upstream 1.26 and then bringing it into openshift.

Note: We can defer the decision on whether to merge this revert until Monday, but with CoreOS 9.2 about to land I'd feel better having CI in the best shape it can be for all platforms.

cc: @sanchezl @soltysh

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Feb 17, 2023

/hold

Will decide on Monday

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023
@openshift-ci openshift-ci Bot requested review from bparees and bthurber February 17, 2023 19:56
@openshift-ci openshift-ci Bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files labels Feb 17, 2023
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Feb 17, 2023

I'll be out on monday, but if this is needed.

Also, how did payload testing not reveal a vsphere problem?

/approve

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Feb 17, 2023 •
edited
Loading

Also, how did payload testing not reveal a vsphere problem?

I may have missed it in all the comments, but I only see blocking ci/nightly jobs checked.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 17, 2023

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 00be076 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 00be076 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-csi 00be076 link false /test e2e-aws-csi
ci/prow/e2e-openstack-ovn 00be076 link false /test e2e-openstack-ovn
ci/prow/e2e-azure-ovn-etcd-scaling 00be076 link false /test e2e-azure-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link
Copy Markdown

openshift-trt-bot commented Feb 17, 2023

Job Failure Risk Analysis for sha: 00be076

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-openstack-ovn Medium
pull-ci-openshift-origin-master-e2e-azure-ovn-etcd-scaling Medium
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Feb 20, 2023

/payload-job periodic-ci-openshift-release-master-nightly-4.13-e2e-vsphere-sdn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 20, 2023

@stbenjam: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.13-e2e-vsphere-sdn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/64f183a0-b121-11ed-84c2-d6b80c036257-0

@EmilienM EmilienM mentioned this pull request Feb 20, 2023
Merged
@jcpowermac jcpowermac mentioned this pull request Feb 20, 2023
Merged
3 tasks
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Feb 20, 2023

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2023
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Feb 20, 2023

/label approved

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
soltysh
soltysh approved these changes Feb 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM
Copy link
Copy Markdown
Member

EmilienM commented Feb 20, 2023 •
edited
Loading

The e2e-openstack-ovn job error has been fixed via openshift/openstack-test#88 and can safely be ignored.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 20, 2023

/retest-required

Remaining retests: 0 against base HEAD 2b61865 and 2 for PR HEAD 00be076 in total

@openshift-merge-robot openshift-merge-robot merged commit 1135825 into openshift:master Feb 20, 2023
sanchezl added a commit to sanchezl/origin that referenced this pull request Feb 20, 2023
@sanchezl
Revert "Merge pull request openshift#27736 from stbenjam/revert-27694…
b465530 
…-bump-1.26"

This reverts commit 1135825, reversing
changes made to 2b61865.
@sanchezl sanchezl mentioned this pull request Feb 20, 2023
Merged
tjungblu pushed a commit to tjungblu/origin that referenced this pull request Apr 11, 2023
@sanchezl @tjungblu
Revert "Merge pull request openshift#27736 from stbenjam/revert-27694…
20d2fef 
…-bump-1.26"

This reverts commit 1135825, reversing
changes made to 2b61865.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@bthurber bthurber Awaiting requested review from bthurber

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stbenjam @deads2k @openshift-trt-bot @EmilienM @openshift-ci-robot @soltysh @openshift-merge-robot