Skip to content

OSDOCS-5192-SPLAT: Added content for SPLAT failure-domain work#55531

Merged
sheriff-rh merged 1 commit into
openshift:mainfrom
dfitzmau:OSDOCS-5192-SPLAT
Apr 5, 2023
Merged

OSDOCS-5192-SPLAT: Added content for SPLAT failure-domain work#55531
sheriff-rh merged 1 commit into
openshift:mainfrom
dfitzmau:OSDOCS-5192-SPLAT

Conversation

@dfitzmau
Copy link
Copy Markdown
Contributor

@dfitzmau dfitzmau commented Feb 3, 2023 •
edited
Loading

OSDOCS-5192

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5192

Link to docs preview:
Multiple failure domain configuration for a cluster on vSphere

QE review:

  • QE has approved this change.

Additional information:

@dfitzmau dfitzmau marked this pull request as draft February 3, 2023 10:22
@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2023
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Feb 3, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://55531--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/13308

@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-5192-SPLAT branch 3 times, most recently from 3abba90 to 8f824df Compare February 3, 2023 16:03
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-5192-SPLAT branch 3 times, most recently from 7dd9e55 to 72ac50a Compare February 7, 2023 10:20
@dfitzmau dfitzmau marked this pull request as ready for review February 7, 2023 10:22
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-5192-SPLAT branch 4 times, most recently from 67f5c22 to 2b4faf6 Compare February 7, 2023 11:09
@dfitzmau
Copy link
Copy Markdown
Contributor Author

dfitzmau commented Feb 7, 2023

Hello @rvanderp3 .

I've rearranged your content from #54788 . Would you be OK to review the content in my PR?

dfitzmau
dfitzmau commented Feb 16, 2023
View reviewed changes
Comment thread modules/specifying-infrastructure-vsphere-failure-domains.adoc Outdated
dfitzmau
dfitzmau commented Feb 16, 2023
View reviewed changes
Comment thread modules/specifying-infrastructure-vsphere-failure-domains.adoc Outdated
@lpettyjo lpettyjo mentioned this pull request Feb 21, 2023
Merged
1 task
rvanderp3
rvanderp3 reviewed Mar 1, 2023
View reviewed changes
Comment thread modules/specifying-infrastructure-vsphere-failure-domains.adoc Outdated
Comment thread modules/references-infrastructure-vspshere-failure-domains.adoc Outdated
Comment thread post_installation_configuration/vsphere-failure-domain-configuration.adoc Outdated
Comment thread modules/specifying-infrastructure-vsphere-failure-domains.adoc Outdated
@dfitzmau dfitzmau force-pushed the OSDOCS-5192-SPLAT branch 3 times, most recently from d033ffa to 148c9c3 Compare March 2, 2023 14:12
@dfitzmau dfitzmau force-pushed the OSDOCS-5192-SPLAT branch 2 times, most recently from 935c959 to 8e7f2d5 Compare March 31, 2023 16:16
@dfitzmau
Copy link
Copy Markdown
Contributor Author

dfitzmau commented Mar 31, 2023

Thanks, @jeana-redhat and @nalhadef . I implemented your feedback. Please let me know your thoughts.

@dfitzmau dfitzmau force-pushed the OSDOCS-5192-SPLAT branch 2 times, most recently from ef5962e to 27f9862 Compare April 3, 2023 08:31
@dfitzmau
Copy link
Copy Markdown
Contributor Author

dfitzmau commented Apr 3, 2023

/remove-label peer-review-done

@dfitzmau
Copy link
Copy Markdown
Contributor Author

dfitzmau commented Apr 3, 2023

/label peer-review-needed

@openshift-ci openshift-ci Bot added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels Apr 3, 2023
@sheriff-rh sheriff-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 3, 2023
sheriff-rh
sheriff-rh reviewed Apr 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Some small suggestions.

Comment thread post_installation_configuration/post-install-vsphere-zones-regions-configuration.adoc Outdated
Comment thread post_installation_configuration/post-install-vsphere-zones-regions-configuration.adoc Outdated
Comment thread modules/specifying-regions-zones-infrastructure-vsphere.adoc
@sheriff-rh sheriff-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 3, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-5192-SPLAT branch from 27f9862 to 456b8f1 Compare April 4, 2023 08:34
@dfitzmau
Copy link
Copy Markdown
Contributor Author

dfitzmau commented Apr 4, 2023

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 4, 2023
@jeana-redhat jeana-redhat added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 labels Apr 4, 2023
@jeana-redhat jeana-redhat added this to the Planned for 4.13 GA milestone Apr 4, 2023
jeana-redhat
jeana-redhat reviewed Apr 4, 2023
View reviewed changes
Comment thread post_installation_configuration/post-install-vsphere-zones-regions-configuration.adoc Outdated
@jeana-redhat jeana-redhat removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 4, 2023
@dfitzmau
Copy link
Copy Markdown
Contributor Author

dfitzmau commented Apr 5, 2023

/label merge-review-needed

sheriff-rh
sheriff-rh reviewed Apr 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merging.

@sheriff-rh
Copy link
Copy Markdown
Contributor

sheriff-rh commented Apr 5, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 5, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 5, 2023

@sheriff-rh: new pull request created: #58251

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak
Copy link
Copy Markdown
Contributor

mjpytlak commented Apr 5, 2023

Congrats @dfitzmau!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheriff-rh sheriff-rh sheriff-rh left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

+4 more reviewers

@sgaoshang sgaoshang sgaoshang left review comments

@rvanderp3 rvanderp3 rvanderp3 left review comments

@nalhadef nalhadef nalhadef left review comments

@mjpytlak mjpytlak mjpytlak left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sgaoshang sgaoshang

Labels

branch/enterprise-4.13 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

4.13 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@dfitzmau @ocpdocs-previewbot @rvanderp3 @sgaoshang @nalhadef @sheriff-rh @openshift-cherrypick-robot @mjpytlak @jeana-redhat