Skip to content

OSDOCS-5234:vSphere topology in installer#56145

Merged
lpettyjo merged 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-5234
May 11, 2023
Merged

OSDOCS-5234:vSphere topology in installer#56145
lpettyjo merged 1 commit into
openshift:mainfrom
lpettyjo:OSDOCS-5234

Conversation

@lpettyjo
Copy link
Copy Markdown
Contributor

@lpettyjo lpettyjo commented Feb 20, 2023 •
edited
Loading

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 20, 2023 •
edited by openshift-ci Bot
Loading

@lpettyjo: This pull request references OSDOCS-5234 which is a valid jira issue.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2023
@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 20, 2023 •
edited by openshift-ci Bot
Loading

@lpettyjo: This pull request references OSDOCS-5234 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OSDOCS-5234

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo added this to the Planned for 4.13 GA milestone Feb 20, 2023
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Feb 20, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://56145--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/15970

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 20, 2023 •
edited by openshift-ci Bot
Loading

@lpettyjo: This pull request references OSDOCS-5234 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OSDOCS-5234

Link to docs preview: https://56145--docspreview.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html#persistent-storage-csi-vsphere-top-aware_persistent-storage-csi-vsphere

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 21, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 21, 2023 •
edited by openshift-ci Bot
Loading

@lpettyjo: This pull request references OSDOCS-5234 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OSDOCS-5234

Link to docs preview: https://56145--docspreview.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html#persistent-storage-csi-vsphere-top-aware_persistent-storage-csi-vsphere

QE review:

  • QE has approved this change.

Additional information:

PTAL: @gnufied, @duanwei33, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo requested a review from gnufied February 21, 2023 15:19
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 21, 2023 •
edited by openshift-ci Bot
Loading

@lpettyjo: This pull request references OSDOCS-5234 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OSDOCS-5234

Link to docs preview: https://56145--docspreview.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html#persistent-storage-csi-vsphere-top-aware_persistent-storage-csi-vsphere

Post install content covered in this PR: #55531

QE review:

  • QE has approved this change.

Additional information:

PTAL: @gnufied, @duanwei33, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@opayne1 opayne1 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 21, 2023
opayne1
opayne1 reviewed Feb 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment from me. I see still pending for reviews from dev/QE.

Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 21, 2023
@duanwei33
Copy link
Copy Markdown

duanwei33 commented Mar 15, 2023 •
edited
Loading

@lpettyjo Sorry I missed the notification.
From 4.13, once the failure domain are configurated during the installation or day-2 action, we don't need to update the clusterCSIDriver object any more for storage part, so:

  • step 2/3/5/6 should be removed
  • step 1/4 should be rewritten to introduce the failure domains / tags and how it works during the installation or day-2 action. (I think installer should have some update on their part to configurate the failure domain, there is day-2 action mentioned in installer PR: OSDOCS-5192-SPLAT: Added content for SPLAT failure-domain work #55531)

cc @gnufied

@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2023
@gnufied
Copy link
Copy Markdown
Member

gnufied commented Apr 6, 2023 •
edited
Loading

IMO we should reword the CSI docs, so as we can point users to install docs for defining a topology but it should still be possible to define a CSI topology even if cluster doesn't have one.

So I am not sure if it is worth removing all the older docs. We could say - preferred way of defining topology of a cluster is to define failure-domains during installation or adding failure-domains as day2-operation. And here we could point users to documentation that shows how failure-domains can be defined.

We should still keep existing docs in case users wants to define a storage topology but does not necessarily want a infra topology.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 7, 2023 •
edited by openshift-ci Bot
Loading

@lpettyjo: This pull request references OSDOCS-5234 which is a valid jira issue.

Details

In response to this:

The last several CSI storage drivers (Azure Hub, AWS EFS, AliCloud, IBM) were not added in the following locations: Access mode, PV types, and Block volume support).

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OSDOCS-5234

Link to docs preview: https://56145--docspreview.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html#persistent-storage-csi-vsphere-top-aware_persistent-storage-csi-vsphere

Post install content covered in this PR: #55531

QE review:

  • QE has approved this change.

Additional information:

PTAL: @gnufied, @duanwei33, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 7, 2023 •
edited by openshift-ci Bot
Loading

@lpettyjo: This pull request references OSDOCS-5234 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OSDOCS-5234

Link to docs preview: https://56145--docspreview.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vsphere.html#persistent-storage-csi-vsphere-top-aware_persistent-storage-csi-vsphere

Post install content covered in this PR: #55531

QE review:

  • QE has approved this change.

Additional information:

PTAL: @gnufied, @duanwei33, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo
Copy link
Copy Markdown
Contributor Author

lpettyjo commented Apr 20, 2023 •
edited
Loading

@gnufied PTAL my changes in response to your comment.

duanwei33
duanwei33 reviewed Apr 21, 2023
View reviewed changes
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
<1> PV has zoned keys.
<2> PV is using the zoned storage class.

== Creating vSphere toplogy without an infra topology
Copy link
Copy Markdown

@duanwei33 duanwei33 Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnufied I understand the prerequisite is we don't have more than 2 failure domain in infrastructures, otherwise we are not allowed to have topology both in "failure domain" and "ClusterCSIDriver". See https://issues.redhat.com/browse/STOR-1123.

Copy link
Copy Markdown
Member

@gnufied gnufied May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not about number of failure-domains though but may be it is worth calling out that:

"Openshift recommends using infrastructure object for specifying failure-domains in a topology aware setup. Specifying failure-domains in infrastructure object and specify topology-categories in ClusterCSIDriver object at the same time is unsupported operation"

Copy link
Copy Markdown
Contributor Author

@lpettyjo lpettyjo May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

gcharot
gcharot reviewed May 5, 2023
View reviewed changes
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
gnufied
gnufied reviewed May 8, 2023
View reviewed changes
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
gnufied
gnufied reviewed May 8, 2023
View reviewed changes
Comment thread modules/persistent-storage-csi-vsphere-top-aware.adoc Outdated
@dfitzmau dfitzmau mentioned this pull request May 9, 2023
Merged
1 task
@lpettyjo lpettyjo force-pushed the OSDOCS-5234 branch 2 times, most recently from 24074ae to 582674f Compare May 10, 2023 00:42
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 10, 2023

@ocpdocs-previewbot: user ocpdocs-previewbot is not trusted for pull request #56145

@gnufied
Copy link
Copy Markdown
Member

gnufied commented May 10, 2023

lgtm

@duanwei33
Copy link
Copy Markdown

duanwei33 commented May 11, 2023

LGTM

@lpettyjo lpettyjo merged commit c32e36b into openshift:main May 11, 2023
@lpettyjo
Copy link
Copy Markdown
Contributor Author

lpettyjo commented May 11, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 11, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented May 11, 2023

@lpettyjo: new pull request created: #59884

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opayne1 opayne1 opayne1 left review comments

+3 more reviewers

@gnufied gnufied gnufied left review comments

@gcharot gcharot gcharot left review comments

@duanwei33 duanwei33 duanwei33 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

4.13 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@lpettyjo @openshift-ci-robot @ocpdocs-previewbot @duanwei33 @gnufied @openshift-cherrypick-robot @gcharot @opayne1