Skip to content

GCP: Revert Instance Type from N2 to N1#5898

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
patrickdillon:revert-gcp-n2
May 12, 2022
Merged

GCP: Revert Instance Type from N2 to N1#5898
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
patrickdillon:revert-gcp-n2

Conversation

@patrickdillon
Copy link
Copy Markdown
Contributor

@patrickdillon patrickdillon commented May 12, 2022

GCP has separate quotas for N2 CPUs: https://cloud.google.com/compute/quotas#cpu_quota
We should revert this change until we're not breaking CI.

These changes were introduced in: 16f2827

GCP has separate quotas for N2 CPUs: https://cloud.google.com/compute/quotas#cpu_quota
We should revert this change until we're not breaking CI.
@openshift-ci openshift-ci Bot requested review from kirankt and sadasu May 12, 2022 11:18
@patrickdillon
Copy link
Copy Markdown
Contributor Author

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@rna-afk
Copy link
Copy Markdown
Contributor

rna-afk commented May 12, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
@nunnatsa
Copy link
Copy Markdown

/retest

@cgwalters
Copy link
Copy Markdown
Member

Just so I understand this, the core problem is the CI account needs a quota bump, then we can re-land this change?

@patrickdillon
Copy link
Copy Markdown
Contributor Author

Just so I understand this, the core problem is the CI account needs a quota bump, then we can re-land this change?

Precisely. (or we solve the ci problem another way.) But I don't want to break all of GCP CI for the last day of FF.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Copy Markdown
Contributor Author

/skip

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Copy Markdown
Member

Sorry I'm just going to drop in here with a hammer 🔨
This can't affect AWS so
/override ci/prow/e2e-aws

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 12, 2022

@cgwalters: cgwalters unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

Details

In response to this:

Sorry I'm just going to drop in here with a hammer 🔨
This can't affect AWS so
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Copy Markdown
Contributor Author

/override ci/prow/e2e-aws

but don't think that is required here

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 12, 2022

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aws

but don't think that is required here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot merged commit 738a7ee into openshift:master May 12, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 12, 2022

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt e6bbf3e link false /test e2e-libvirt
ci/prow/e2e-metal-ipi e6bbf3e link false /test e2e-metal-ipi
ci/prow/e2e-crc e6bbf3e link false /test e2e-crc
ci/prow/okd-e2e-aws e6bbf3e link false /test okd-e2e-aws
ci/prow/e2e-vsphere e6bbf3e link false /test e2e-vsphere
ci/prow/e2e-ibmcloud e6bbf3e link false /test e2e-ibmcloud
ci/prow/e2e-metal-assisted e6bbf3e link false /test e2e-metal-assisted

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Copy Markdown
Member

wking commented Jun 29, 2022

#6058 is taking a second run at moving to n2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants