Skip to content

OSDOCS-3638: Release note for AWS/vSphere default compute node resources#45819

Merged
maxwelldb merged 1 commit intoopenshift:enterprise-4.11from
mjpytlak:osdocs-3638-rn
May 27, 2022
Merged

OSDOCS-3638: Release note for AWS/vSphere default compute node resources#45819
maxwelldb merged 1 commit intoopenshift:enterprise-4.11from
mjpytlak:osdocs-3638-rn

Conversation

@mjpytlak
Copy link
Copy Markdown
Contributor

@mjpytlak mjpytlak commented May 18, 2022 •
edited
Loading

Version(s):
CP to 4.11

Issue:
This PR addresses OSDOCS-3638 and CORS-2021

Link to docs preview:
Default AWS and VMware vSphere compute node resources

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 4074c6a5efdc54b3a56eee755b532edeb01c588d
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/628511b9e1d32d00081ed179
😎 Deploy Preview https://deploy-preview-45819--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-11-release-notes
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented May 18, 2022 •
edited by openshift-ci Bot
Loading

@rna-afk Release note related to your work for CORS-2021 is ready for SME review. Please take a look.Thank you.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2022
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2022
rna-afk
rna-afk reviewed May 25, 2022
View reviewed changes
Comment thread release_notes/ocp-4-11-release-notes.adoc Outdated
Copy link
Copy Markdown

@rna-afk rna-afk May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In AWS we pick the instance type that provides 4 vCPUs and 16GB RAM but for Vsphere, we do not have instance types. We set the vCPUs and RAM ourselves.

Copy link
Copy Markdown
Contributor Author

@mjpytlak mjpytlak May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. In light of that, I believe we do not have to say "how" the node is deployed, but rather simply that they are now deployed with 4 CPU/16 GB RAM.

rna-afk
rna-afk reviewed May 25, 2022
View reviewed changes
Comment thread release_notes/ocp-4-11-release-notes.adoc Outdated
Copy link
Copy Markdown

@rna-afk rna-afk May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to add "by default"

Copy link
Copy Markdown
Contributor Author

@mjpytlak mjpytlak May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Good catch.

@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented May 25, 2022

@yunjiang29 @jinyunma Have a 4.11 release note for default AWS/vSphere compute node resources that is ready for QE review. PTAL. Thank you.

@jinyunma
Copy link
Copy Markdown

jinyunma commented May 26, 2022 •
edited
Loading

Installer PR openshift/installer#5841 updates default cpu/memory for compute node on AWS/vSphere/GCP in 4.11, seems missing GCP here?

@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented May 26, 2022 •
edited
Loading

Installer PR openshift/installer#5841 updates default cpu/memory for compute node on AWS/vSphere/GCP in 4.11, seems missing GCP here?

GCP didn't land in 4.11. openshift/installer#5898

@yunjiang29
Copy link
Copy Markdown
Contributor

yunjiang29 commented May 27, 2022

@mjpytlak lgtm, thanks for the updates!

@jinyunma
Copy link
Copy Markdown

jinyunma commented May 27, 2022

LGTM

@rna-afk
Copy link
Copy Markdown

rna-afk commented May 27, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@maxwelldb maxwelldb self-requested a review May 27, 2022 13:58
@maxwelldb maxwelldb added this to the Future Release milestone May 27, 2022
@maxwelldb maxwelldb merged commit bec7987 into openshift:enterprise-4.11 May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxwelldb maxwelldb maxwelldb approved these changes

+1 more reviewer

@rna-afk rna-afk rna-afk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rna-afk rna-afk

Labels

branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.11 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@mjpytlak @jinyunma @yunjiang29 @rna-afk @maxwelldb @kalexand-rh