Skip to content

vSphere: Zonal Terraform#6064

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jcpowermac:vsphere-terraform-zoning
Sep 12, 2022
Merged

vSphere: Zonal Terraform#6064
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jcpowermac:vsphere-terraform-zoning

Conversation

@jcpowermac
Copy link
Copy Markdown
Contributor

@jcpowermac jcpowermac commented Jun 30, 2022 •
edited
Loading

This PR adds an additional terraform workflow
and variables to allow for the provisioning
of the RHCOS OVA (template), bootstrap and
control plane nodes into a zonal installation.

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 30, 2022
@jcpowermac jcpowermac force-pushed the vsphere-terraform-zoning branch from 457d072 to 205cc94 Compare June 30, 2022 14:02
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jun 30, 2022

/test e2e-vsphere

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jun 30, 2022

/test e2e-vsphere-zone

@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2022
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jun 30, 2022

/test e2e-vsphere-zones

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 30, 2022

@jcpowermac: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test aro-unit
  • /test e2e-aws
  • /test e2e-aws-upi
  • /test e2e-azure
  • /test e2e-azure-upi
  • /test e2e-gcp
  • /test e2e-gcp-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-alibaba
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-imdsv2
  • /test e2e-aws-proxy
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi-proxy
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure-resourcegroup
  • /test e2e-azure-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-swapped-hosts
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix
  • /test e2e-openstack
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-parallel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere-zones
  • /test okd-e2e-aws
  • /test okd-e2e-aws-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-upgrade
  • /test okd-e2e-vsphere
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws
  • pull-ci-openshift-installer-master-e2e-azure
  • pull-ci-openshift-installer-master-e2e-gcp
  • pull-ci-openshift-installer-master-e2e-ibmcloud
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-assisted
  • pull-ci-openshift-installer-master-e2e-metal-ipi
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-e2e-vsphere
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/test e2e-vsphere-zone

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jun 30, 2022

/test e2e-vsphere-zones

@openshift-ci openshift-ci Bot requested review from AnnaZivkovic and jstuever June 30, 2022 14:17
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jun 30, 2022

/uncc AnnaZivkovic
/uncc jstuever

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jun 30, 2022

/test e2e-vsphere-zones

2 similar comments
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jul 1, 2022

/test e2e-vsphere-zones

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jul 6, 2022

/test e2e-vsphere-zones

@jcpowermac jcpowermac force-pushed the vsphere-terraform-zoning branch from 797dee8 to ef6c5f9 Compare July 6, 2022 18:45
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jul 6, 2022

/test e2e-vsphere-zones

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jul 6, 2022

openshift/release#30187

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2022
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jul 7, 2022

/test e2e-vsphere-zones

@jcpowermac jcpowermac force-pushed the vsphere-terraform-zoning branch from ef6c5f9 to 05432ed Compare July 7, 2022 17:31
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 7, 2022
@jcpowermac jcpowermac force-pushed the vsphere-terraform-zoning branch from 14e987e to df65370 Compare July 8, 2022 00:45
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2022
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Jul 8, 2022

/test e2e-vsphere-zones

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2022
@jcpowermac jcpowermac force-pushed the vsphere-terraform-zoning branch from df65370 to b3b67c6 Compare July 18, 2022 16:57
@rvanderp3
Copy link
Copy Markdown
Contributor

rvanderp3 commented Sep 8, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@patrickdillon
Copy link
Copy Markdown
Contributor

patrickdillon commented Sep 9, 2022

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 9, 2022

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 9, 2022

/retest-required

Remaining retests: 0 against base HEAD 28510e3 and 2 for PR HEAD cf912f7777d4b992870f787b90af10d38ba1a81f in total

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 10, 2022

/retest-required

@jcpowermac
vSphere: Continue with changes to support zonal
e795629 
This PR adds an additional terraform workflow
and variables to allow for the provisioning
of the RHCOS OVA (template), bootstrap and
control plane nodes into a zonal installation.
@jcpowermac jcpowermac force-pushed the vsphere-terraform-zoning branch from cf912f7 to e795629 Compare September 10, 2022 13:40
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2022
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 10, 2022

@rvanderp3 or @patrickdillon
had to rebase for a conflict if I could get a lgtm please

@rvanderp3
Copy link
Copy Markdown
Contributor

rvanderp3 commented Sep 10, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2022
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 10, 2022

/retest-required

Remaining retests: 0 against base HEAD a6d5133 and 2 for PR HEAD e795629 in total

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 10, 2022

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 11, 2022

/retest-required

Remaining retests: 0 against base HEAD 4d3796f and 1 for PR HEAD e795629 in total

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 11, 2022

/retest-required

@jcpowermac jcpowermac mentioned this pull request Sep 11, 2022
Merged
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 11, 2022

ugh ci :(

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 11, 2022

/retest-required

Remaining retests: 0 against base HEAD f0cdc99 and 0 for PR HEAD e795629 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 11, 2022

/hold

Revision e795629 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2022
@rvanderp3
Copy link
Copy Markdown
Contributor

rvanderp3 commented Sep 11, 2022

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2022
@rvanderp3
Copy link
Copy Markdown
Contributor

rvanderp3 commented Sep 11, 2022

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 12, 2022

/retest-required

Remaining retests: 0 against base HEAD f0cdc99 and 2 for PR HEAD e795629 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 12, 2022

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws e0a76552515a1e39f2eb6af90cfb89b6cc37f7c8 link false /test okd-e2e-aws
ci/prow/e2e-ibmcloud cf912f7777d4b992870f787b90af10d38ba1a81f link false /test e2e-ibmcloud
ci/prow/e2e-vsphere-zones cf912f7777d4b992870f787b90af10d38ba1a81f link false /test e2e-vsphere-zones
ci/prow/e2e-ibmcloud-ovn e795629 link false /test e2e-ibmcloud-ovn
ci/prow/okd-e2e-gcp-ovn-upgrade e795629 link false /test okd-e2e-gcp-ovn-upgrade
ci/prow/e2e-libvirt e795629 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 618f468 into openshift:master Sep 12, 2022
@jcpowermac jcpowermac mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

+1 more reviewer

@rvanderp3 rvanderp3 rvanderp3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

@rvanderp3 rvanderp3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jcpowermac @rvanderp3 @patrickdillon @openshift-ci-robot @openshift-merge-robot