vsphere zonal: platform spec and terraform updates#6329
Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom Sep 14, 2022
Merged
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
jcpowermac
force-pushed
the
vsphere-zonal-terraform-platform-updates
branch
2 times, most recently
from
462bef0 to
eab941d
Compare
Contributor
Author
jcpowermac
force-pushed
the
vsphere-zonal-terraform-platform-updates
branch
2 times, most recently
from
90b2133 to
682ddab
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
Author
|
/test e2e-vsphere-zones |
Contributor
Author
nm, we need to merge openshift/release#32178 |
openshift-merge-robot
added
the
needs-rebase
jcpowermac
force-pushed
the
vsphere-zonal-terraform-platform-updates
branch
from
682ddab to
77396d1
Compare
openshift-merge-robot
removed
the
needs-rebase
jcpowermac
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/assign @patrickdillon |
Contributor
Author
|
/retest-required |
Contributor
|
/test govet |
This commit makes changes to the terraform modules and variables to support the recent changes in the platform spec. Which greatly reduces the complexity of a zonal installation.
platform spec updates to reflect enhancement
jcpowermac
force-pushed
the
vsphere-zonal-terraform-platform-updates
branch
from
77396d1 to
20a8ba6
Compare
Contributor
Author
|
/test e2e-vsphere-zones |
Setting the configmap to the expected naming.
Contributor
Author
|
/test e2e-vsphere-zones |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
/lgtm |
Contributor
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
Contributor
Contributor
|
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Contributor
Author
|
/retest-required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the changes from @rvanderp3 and I that updates the platform spec to conform to the changes in openshift/api#1278. The changes greatly reduce the complexity of the zonal platform spec.