[release-4.11] OCPBUGS-4081: OpenStack: Force JSON content-type in Swift by openshift-cherrypick-robot · Pull Request #6625 · openshift/installer

openshift-cherrypick-robot · 2022-11-24T11:31:12Z

This is an automated cherry-pick of #6621

/assign pierreprinetti

Some OpenStack object storages respond with `204 No Content` to list requests when there are no containers or objects to list. In these cases, when responding to requests with an `Accept: text/plain` or no `Accept` header, some object storages omit the `content-type` header in their status-204 responses. Now, Gophercloud throws an error when the response does not contain a `content-type` header. With this change, we work around the issue by forcing Gophercloud to request a JSON response from the object storage when listing containers. When passed an `Accept: application/json` header, the server responds with `220 Ok` and a `content-type` header in our tests. This solution gives us a fix that is easily backportable because it doesn't require any dependency bump. Note that in my local tests, I didn't find the 'full' listing to take more time than the short, name-only response we were requesting Swift prior to this change.

openshift-ci-robot · 2022-11-24T11:31:18Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-4063 has been cloned as Jira Issue OCPBUGS-4081. Retitling PR to link against new bug.
/retitle [release-4.11] OCPBUGS-4081: OpenStack: Force JSON content-type in Swift

Details

In response to this:

This is an automated cherry-pick of #6621

/assign pierreprinetti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-24T11:31:51Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.11] OCPBUGS-4081: OpenStack: Force JSON content-type in Swift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-11-24T11:31:53Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-4081, which is invalid:

expected dependent Jira Issue OCPBUGS-4063 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #6621

/assign pierreprinetti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-11-24T12:00:54Z

/approve
/lgtm
/hold for the tests

openshift-ci · 2022-11-24T12:01:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/destroy/openstack/OWNERS~~ [pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierreprinetti · 2022-11-24T13:22:47Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-11-24T13:22:49Z

@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-11-24T16:13:32Z

/test e2e-openstack

openshift-ci · 2022-11-24T19:53:18Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-parallel	`d03445b`	link	false	`/test e2e-openstack-parallel`
ci/prow/e2e-aws-upi-proxy	`d03445b`	link	false	`/test e2e-aws-upi-proxy`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre

CI is happy.
/hold cancel
/label backport-risk-assessed

pierreprinetti · 2022-11-25T08:42:42Z

/jira refresh
/woof

openshift-ci-robot · 2022-11-25T08:42:49Z

@pierreprinetti: This pull request references Jira Issue OCPBUGS-4081, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-4063 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-4063 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
bug has dependents

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

/jira refresh
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-25T08:43:01Z

@pierreprinetti:

Details

In response to this:

/jira refresh
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-11-25T09:51:36Z

/assign @itzikb-redhat

itzikb-redhat · 2022-11-27T08:22:05Z

/label cherry-pick-approved

openshift-cherrypick-robot · 2022-11-27T08:26:18Z

@pierreprinetti: new pull request created: #6628

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-11-28T14:28:57Z

/jira refresh

openshift-ci-robot · 2022-11-28T14:29:00Z

@pierreprinetti: All pull requests linked via external trackers have merged:

openshift/installer#6625

Jira Issue OCPBUGS-4081 has been moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot assigned pierreprinetti Nov 24, 2022

openshift-cherrypick-robot mentioned this pull request Nov 24, 2022

[release-4.12] OCPBUGS-4063: OpenStack: Force JSON content-type in Swift #6621

Merged

openshift-ci Bot changed the title ~~[release-4.11] OCPBUGS-4063: OpenStack: Force JSON content-type in Swift~~ [release-4.11] OCPBUGS-4081: OpenStack: Force JSON content-type in Swift Nov 24, 2022

openshift-ci-robot added the jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. label Nov 24, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 24, 2022

openshift-ci Bot requested review from MaysaMacedo and mdbooth November 24, 2022 11:32

openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Nov 24, 2022

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022

mandre reviewed Nov 25, 2022

View reviewed changes

openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 25, 2022

openshift-ci Bot requested a review from eurijon November 25, 2022 08:43

openshift-ci Bot assigned itzikb-redhat Nov 25, 2022

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 27, 2022

openshift-merge-robot merged commit 050fa95 into openshift:release-4.11 Nov 27, 2022

openshift-cherrypick-robot mentioned this pull request Nov 27, 2022

[release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift #6628

Merged

Conversation

openshift-cherrypick-robot commented Nov 24, 2022

Uh oh!

openshift-ci-robot commented Nov 24, 2022

Uh oh!

openshift-ci Bot commented Nov 24, 2022

Uh oh!

openshift-ci-robot commented Nov 24, 2022

Uh oh!

pierreprinetti commented Nov 24, 2022

Uh oh!

openshift-ci Bot commented Nov 24, 2022

Uh oh!

pierreprinetti commented Nov 24, 2022

Uh oh!

openshift-cherrypick-robot commented Nov 24, 2022

Uh oh!

pierreprinetti commented Nov 24, 2022

Uh oh!

openshift-ci Bot commented Nov 24, 2022

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

pierreprinetti commented Nov 25, 2022

Uh oh!

openshift-ci-robot commented Nov 25, 2022

Uh oh!

openshift-ci Bot commented Nov 25, 2022

Uh oh!

pierreprinetti commented Nov 25, 2022

Uh oh!

itzikb-redhat commented Nov 27, 2022

Uh oh!

openshift-cherrypick-robot commented Nov 27, 2022

Uh oh!

pierreprinetti commented Nov 28, 2022

Uh oh!

openshift-ci-robot commented Nov 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants