[release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift by openshift-cherrypick-robot · Pull Request #6628 · openshift/installer

openshift-cherrypick-robot · 2022-11-27T08:26:17Z

This is an automated cherry-pick of #6625

/assign pierreprinetti

Some OpenStack object storages respond with `204 No Content` to list requests when there are no containers or objects to list. In these cases, when responding to requests with an `Accept: text/plain` or no `Accept` header, some object storages omit the `content-type` header in their status-204 responses. Now, Gophercloud throws an error when the response does not contain a `content-type` header. With this change, we work around the issue by forcing Gophercloud to request a JSON response from the object storage when listing containers. When passed an `Accept: application/json` header, the server responds with `220 Ok` and a `content-type` header in our tests. This solution gives us a fix that is easily backportable because it doesn't require any dependency bump. Note that in my local tests, I didn't find the 'full' listing to take more time than the short, name-only response we were requesting Swift prior to this change.

pierreprinetti · 2022-11-27T10:48:05Z

/approve
/lgtm

itzikb-redhat · 2022-11-27T10:49:13Z

/label cherry-pick-approved

pierreprinetti · 2022-11-27T22:16:03Z

/retest

openshift-ci · 2022-11-28T01:37:41Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-vsphere	`17a698b`	link	false	`/test okd-e2e-vsphere`
ci/prow/e2e-azurestack	`17a698b`	link	false	`/test e2e-azurestack`
ci/prow/e2e-azurestack-upi	`17a698b`	link	false	`/test e2e-azurestack-upi`
ci/prow/e2e-alibaba	`17a698b`	link	false	`/test e2e-alibaba`
ci/prow/e2e-openstack	`17a698b`	link	false	`/test e2e-openstack`
ci/prow/okd-e2e-gcp-upgrade	`17a698b`	link	false	`/test okd-e2e-gcp-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre

/lgtm
/approve
/label backport-risk-assessed

openshift-ci · 2022-11-28T08:59:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/destroy/openstack/OWNERS~~ [mandre,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierreprinetti · 2022-11-28T09:15:57Z

/retitle [release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift

openshift-ci · 2022-11-28T09:16:02Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-11-28T09:16:39Z

/jira refresh

pierreprinetti · 2022-11-28T11:30:07Z

OCPBUGS-4160

pierreprinetti · 2022-11-28T14:26:52Z

/retitle [release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift

openshift-ci · 2022-11-28T14:26:57Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-11-28T14:28:27Z

/retitle [release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift
/jira refresh

openshift-ci · 2022-11-28T14:28:31Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-11-28T14:28:32Z

@pierreprinetti: This pull request references Jira Issue OCPBUGS-4160, which is invalid:

expected dependent Jira Issue OCPBUGS-4081 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/retitle [release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2022-11-29T08:33:29Z

/jira refresh

openshift-ci-robot · 2022-11-29T08:33:35Z

@pierreprinetti: This pull request references Jira Issue OCPBUGS-4160, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.10.z) matches configured target version for branch (4.10.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-4081 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-4081 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
bug has dependents

Requesting review from QA contact:
/cc @eurijon

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-11-29T08:39:10Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/installer#6628

Jira Issue OCPBUGS-4160 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6625

/assign pierreprinetti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Nov 27, 2022

[release-4.11] OCPBUGS-4081: OpenStack: Force JSON content-type in Swift #6625

Merged

openshift-cherrypick-robot assigned pierreprinetti Nov 27, 2022

openshift-ci Bot requested review from mandre and pierreprinetti November 27, 2022 08:27

openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 27, 2022

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 27, 2022

mandre reviewed Nov 28, 2022

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 28, 2022

openshift-ci Bot assigned mandre Nov 28, 2022

openshift-ci Bot changed the title ~~[release-4.10] OCPBUGS-4081: OpenStack: Force JSON content-type in Swift~~ [release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift Nov 28, 2022

openshift-ci Bot changed the title ~~[release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift~~ [release-4.10] OCPBUGS-4160: OpenStack: Force JSON content-type in Swift Nov 28, 2022

openshift-ci-robot added the jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. label Nov 28, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 28, 2022

openshift-ci Bot requested a review from eurijon November 29, 2022 08:33

openshift-merge-robot merged commit 4f9fb72 into openshift:release-4.10 Nov 29, 2022

pierreprinetti mentioned this pull request Jan 20, 2023

OCPBUGS-6086: OpenStack: Force JSON content-type in Swift #6787

Merged

Conversation

openshift-cherrypick-robot commented Nov 27, 2022

Uh oh!

pierreprinetti commented Nov 27, 2022

Uh oh!

itzikb-redhat commented Nov 27, 2022

Uh oh!

pierreprinetti commented Nov 27, 2022

Uh oh!

openshift-ci Bot commented Nov 28, 2022

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Nov 28, 2022

Uh oh!

pierreprinetti commented Nov 28, 2022

Uh oh!

openshift-ci Bot commented Nov 28, 2022

Uh oh!

pierreprinetti commented Nov 28, 2022

Uh oh!

pierreprinetti commented Nov 28, 2022

Uh oh!

pierreprinetti commented Nov 28, 2022

Uh oh!

openshift-ci Bot commented Nov 28, 2022

Uh oh!

pierreprinetti commented Nov 28, 2022

Uh oh!

openshift-ci Bot commented Nov 28, 2022

Uh oh!

openshift-ci-robot commented Nov 28, 2022

Uh oh!

pierreprinetti commented Nov 29, 2022

Uh oh!

openshift-ci-robot commented Nov 29, 2022

Uh oh!

openshift-ci-robot commented Nov 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants