OCPBUGS-6086: OpenStack: Force JSON content-type in Swift by pierreprinetti · Pull Request #6787 · openshift/installer

pierreprinetti · 2023-01-20T08:30:45Z

This is a combined backport of #6628 and #6726

Some OpenStack object storages respond with 204 No Content to list requests when there are no containers or objects to list. In these cases, when responding to requests with an Accept: text/plain or no Accept header, some object storages omit the content-type header in their status-204 responses.

Now, Gophercloud throws an error when the response does not contain a content-type header.

With this change, we work around the issue by forcing Gophercloud to request a JSON response from the object storage when listing containers. When passed an Accept: application/json header, the server responds with 220 OK and a content-type header in our tests.

This solution gives us a fix that is easily backportable because it doesn't require any dependency bump.

Some OpenStack object storages respond with `204 No Content` to list requests when there are no containers or objects to list. In these cases, when responding to requests with an `Accept: text/plain` or no `Accept` header, some object storages omit the `content-type` header in their status-204 responses. Now, Gophercloud throws an error when the response does not contain a `content-type` header. With this change, we work around the issue by forcing Gophercloud to request a JSON response from the object storage when listing containers. When passed an `Accept: application/json` header, the server responds with `220 OK` and a `content-type` header in our tests. This solution gives us a fix that is easily backportable because it doesn't require any dependency bump.

openshift-ci · 2023-01-20T08:30:48Z

@pierreprinetti: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-6086: OpenStack: Force JSON content-type in Swift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-20T08:30:49Z

@pierreprinetti: This pull request references Jira Issue OCPBUGS-6086, which is invalid:

expected the bug to target the "4.9.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a combined backport of #6628 and #6726

Some OpenStack object storages respond with 204 No Content to list requests when there are no containers or objects to list. In these cases, when responding to requests with an Accept: text/plain or no Accept header, some object storages omit the content-type header in their status-204 responses.

Now, Gophercloud throws an error when the response does not contain a content-type header.

With this change, we work around the issue by forcing Gophercloud to request a JSON response from the object storage when listing containers. When passed an Accept: application/json header, the server responds with 220 OK and a content-type header in our tests.

This solution gives us a fix that is easily backportable because it doesn't require any dependency bump.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2023-01-20T08:31:31Z

/jira refresh
/cherry-pick release-4.8

openshift-cherrypick-robot · 2023-01-20T08:31:33Z

@pierreprinetti: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you.

Details

In response to this:

/jira refresh
/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-20T08:31:38Z

@pierreprinetti: This pull request references Jira Issue OCPBUGS-6086, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.9.z) matches configured target version for branch (4.9.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-4160 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-4160 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
bug has dependents

Details

In response to this:

/jira refresh
/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre

/lgtm
/approve

mandre · 2023-01-20T09:19:01Z

/label backport-risk-assessed

openshift-ci · 2023-01-20T09:19:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/destroy/openstack/OWNERS~~ [mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierreprinetti · 2023-01-20T10:49:31Z

/retest-required

openshift-ci · 2023-01-20T12:39:54Z

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-single-node-live-iso	`5b33fa2`	link	false	`/test e2e-metal-single-node-live-iso`
ci/prow/e2e-crc	`5b33fa2`	link	false	`/test e2e-crc`
ci/prow/e2e-libvirt	`5b33fa2`	link	false	`/test e2e-libvirt`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pierreprinetti · 2023-01-20T13:01:37Z

/assign @eurijon

eurijon · 2023-01-20T18:06:01Z

/label cherry-pick-approved

openshift-ci-robot · 2023-01-20T18:09:56Z

@pierreprinetti: All pull requests linked via external trackers have merged:

openshift/installer#6787

Jira Issue OCPBUGS-6086 has been moved to the MODIFIED state.

Details

In response to this:

This is a combined backport of #6628 and #6726

Some OpenStack object storages respond with 204 No Content to list requests when there are no containers or objects to list. In these cases, when responding to requests with an Accept: text/plain or no Accept header, some object storages omit the content-type header in their status-204 responses.

Now, Gophercloud throws an error when the response does not contain a content-type header.

With this change, we work around the issue by forcing Gophercloud to request a JSON response from the object storage when listing containers. When passed an Accept: application/json header, the server responds with 220 OK and a content-type header in our tests.

This solution gives us a fix that is easily backportable because it doesn't require any dependency bump.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-01-20T18:11:10Z

@pierreprinetti: new pull request created: #6792

Details

In response to this:

/jira refresh
/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-11-25T01:51:58Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-baremetal-installer-container-v4.9.0-202311250023.p0.g1882c69.assembly.stream for distgit ose-baremetal-installer.
All builds following this will include this PR.

openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 20, 2023

openshift-ci Bot requested review from mandre and mdbooth January 20, 2023 08:31

mandre reviewed Jan 20, 2023

View reviewed changes

openshift-ci Bot assigned mandre Jan 20, 2023

openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Jan 20, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023

mandre mentioned this pull request Jan 20, 2023

OCPBUGS-6035: Merge https://github.com/kubernetes/cloud-provider-openstack:release-1.22 into release-4.9 openshift/cloud-provider-openstack#170

Merged

openshift-ci Bot assigned eurijon Jan 20, 2023

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 20, 2023

openshift-merge-robot merged commit 1882c69 into openshift:release-4.9 Jan 20, 2023

openshift-cherrypick-robot mentioned this pull request Jan 20, 2023

[release-4.8] OCPBUGS-6174: OpenStack: Force JSON content-type in Swift #6792

Merged

pierreprinetti deleted the os_swift_content-type_destroy_containers branch January 20, 2023 23:03

Conversation

pierreprinetti commented Jan 20, 2023

Uh oh!

openshift-ci Bot commented Jan 20, 2023

Uh oh!

openshift-ci-robot commented Jan 20, 2023

Uh oh!

pierreprinetti commented Jan 20, 2023

Uh oh!

openshift-cherrypick-robot commented Jan 20, 2023

Uh oh!

openshift-ci-robot commented Jan 20, 2023

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

mandre commented Jan 20, 2023

Uh oh!

openshift-ci Bot commented Jan 20, 2023

Uh oh!

pierreprinetti commented Jan 20, 2023

Uh oh!

openshift-ci Bot commented Jan 20, 2023

Uh oh!

pierreprinetti commented Jan 20, 2023

Uh oh!

eurijon commented Jan 20, 2023

Uh oh!

openshift-ci-robot commented Jan 20, 2023

Uh oh!

openshift-cherrypick-robot commented Jan 20, 2023

Uh oh!

openshift-bot commented Nov 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants