Skip to content

OCPBUGS-4878: Switch back to gp2 ebs volume type for bootstrap instance#6692

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
montaguethomas:bugfix/aws-region-support
Dec 15, 2022
Merged

OCPBUGS-4878: Switch back to gp2 ebs volume type for bootstrap instance#6692
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
montaguethomas:bugfix/aws-region-support

Conversation

@montaguethomas
Copy link
Copy Markdown
Contributor

PR #5239 switched the default EBS volume type from gp2 to gp3. But in doing so, this breaks support for AWS regions which do not have gp3 (e.g. us-iso-east-1, us-isob-east-1). While it's possible to set the EBS volume type in the install-config for control plane and compute nodes, the bootstrap instance is hardcoded in the terraform.

Since the bootstrap instance is a short lived instance, doesn't require large amounts of iops, and will be destroyed after cluster bootstrapping, switch it back to gp2.

Not all AWS regions support gp3 and this hardcoded value breaks IPI installs
to those regions.
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 12, 2022

Hi @montaguethomas. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Dec 14, 2022

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 14, 2022
@montaguethomas
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@montaguethomas
Copy link
Copy Markdown
Contributor Author

/retest

@patrickdillon
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@montaguethomas thanks for the fix!

/override ci/prow/golint

Known issue with this test timing out, and this PR does not touch go code.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 15, 2022

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/golint

Details

In response to this:

/approve
/lgtm

@montaguethomas thanks for the fix!

/override ci/prow/golint

Known issue with this test timing out, and this PR does not touch go code.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 15, 2022

@montaguethomas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/golint 48d988c link true /test golint
ci/prow/e2e-aws-ovn-disruptive 48d988c link false /test e2e-aws-ovn-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f2195aa into openshift:master Dec 15, 2022
@montaguethomas montaguethomas deleted the bugfix/aws-region-support branch December 15, 2022 03:37
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Dec 15, 2022

/retitle OCPBUGS-4878: Switch back to gp2 ebs volume type for bootstrap instance

@openshift-ci openshift-ci Bot changed the title Switch back to gp2 ebs volume type for bootstrap instance OCPBUGS-4878: Switch back to gp2 ebs volume type for bootstrap instance Dec 15, 2022
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@montaguethomas: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4878 has been moved to the MODIFIED state.

Details

In response to this:

PR #5239 switched the default EBS volume type from gp2 to gp3. But in doing so, this breaks support for AWS regions which do not have gp3 (e.g. us-iso-east-1, us-isob-east-1). While it's possible to set the EBS volume type in the install-config for control plane and compute nodes, the bootstrap instance is hardcoded in the terraform.

Since the bootstrap instance is a short lived instance, doesn't require large amounts of iops, and will be destroyed after cluster bootstrapping, switch it back to gp2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Dec 15, 2022

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Copy Markdown

@r4f4: new pull request created: #6705

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants