OCPVE-675: feat: bump api to add OLM capability#7495
OCPVE-675: feat: bump api to add OLM capability#7495openshift-ci[bot] merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request references OCPVE-675 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
do-not-merge/hold
Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
add-capability-olm
branch
from
4125e9e to
500fd7f
Compare
|
@eggfoobar: This pull request references OCPVE-675 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold This should be good for a review now that API has merged in |
openshift-ci
Bot
removed
the
do-not-merge/hold
added validation check for the hard dependency of marketplace to OLM added unit tests for capability validation ran go generate Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
add-capability-olm
branch
from
500fd7f to
36e0844
Compare
|
/cc @kevinrizza |
|
/lgtm |
| expectedError: `additionalEnabledCapabilities: Invalid value: \[\]v1.ClusterVersionCapability{"marketplace"}: the marketplace capability requires the OperatorLifecycleManager capability`, | ||
| }, | ||
| { | ||
| name: "invalid capability baremetal specified without MachineAPI", |
There was a problem hiding this comment.
Nit: This test seems unrelated to the current PR.
There was a problem hiding this comment.
Apologies, I noticed we were missing one for that case, so I figured it wouldn't hurt to add one since they're a similar code path
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
Bump API to include new OLM capability
Updated validation logic to make sure Marketplace can not be enabled while OLM is disabled. Marketplace has a hard dependency on OLM.
Added unit test for validation addition
/hold
Waiting on API change to be merged in. openshift/api#1589