Skip to content

OCPBUGS-30025: fix: changed validation for olm and marketplace#8609

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
eggfoobar:fix-olm-marketplace-validation
Jun 18, 2024
Merged

OCPBUGS-30025: fix: changed validation for olm and marketplace#8609
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
eggfoobar:fix-olm-marketplace-validation

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

updated the validation logic to check for marketplace and olm to cover different capability sets beyond "none"

updated the validation logic to check for marketplace and olm to cover different capability sets beyond "none"

Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 14, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@eggfoobar: This pull request references Jira Issue OCPBUGS-30025, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

updated the validation logic to check for marketplace and olm to cover different capability sets beyond "none"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from jinyunma June 14, 2024 21:07
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Jun 15, 2024

/cc @sadasu

@openshift-ci openshift-ci Bot requested a review from sadasu June 15, 2024 09:42
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Jun 15, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2024
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Jun 17, 2024

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 18, 2024

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit c84151a into openshift:master Jun 18, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@eggfoobar: Jira Issue OCPBUGS-30025: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30025 has been moved to the MODIFIED state.

Details

In response to this:

updated the validation logic to check for marketplace and olm to cover different capability sets beyond "none"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.17.0-202406180812.p0.gc84151a.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants