Skip to content

OCPBUGS-41642: vendor: Update openshift/api to pick up v4.17 capability sets#9003

Closed
wking wants to merge 1 commit intoopenshift:release-4.17from
wking:release-4.17-v4.17-capability-set
Closed

OCPBUGS-41642: vendor: Update openshift/api to pick up v4.17 capability sets#9003
wking wants to merge 1 commit intoopenshift:release-4.17from
wking:release-4.17-v4.17-capability-set

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Sep 12, 2024

Catching up with openshift/api/pull/2023, and a backport-ish of 9d1f82a8ec (#9002). Generated with:

$ GOPROXY=direct go get github.com/openshift/api@release-4.17
$ go mod tidy
$ go mod vendor
$ go generate ./pkg/types/installconfig.go
$ git add -A go.* vendor data/data/install.openshift.io_installconfigs.yaml

all using:

$ go version
go version go1.23.1 linux/amd64

where GOPROXY=direct avoids a caching delay:

I committed a new change (or released a new version) to a repository, why isn't it showing up when I run go get -u or go list -m --versions?

In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute. Note that if someone requested the version before the tag was pushed, it may take up to 30 minutes for the mirror's cache to expire and fresh data about the version to become available. If the version is still not available after 30 minutes, please file an issue.

This will allow users to use the new capability sets in their install-config YAML.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 12, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@wking: This pull request references Jira Issue OCPBUGS-41642, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Catching up with openshift/api/pull/2023, and a backport-ish of 9d1f82a8ec (#9002). Generated with:

$ GOPROXY=direct go get github.com/openshift/api@release-4.17
$ go mod tidy
$ go mod vendor
$ go generate ./pkg/types/installconfig.go
$ git add -A go.* vendor data/data/install.openshift.io_installconfigs.yaml

all using:

$ go version
go version go1.22.2 linux/amd64

where GOPROXY=direct avoids a caching delay:

I committed a new change (or released a new version) to a repository, why isn't it showing up when I run go get -u or go list -m --versions?

In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute. Note that if someone requested the version before the tag was pushed, it may take up to 30 minutes for the mirror's cache to expire and fresh data about the version to become available. If the version is still not available after 30 minutes, please file an issue.

This will allow users to use the new capability sets in their install-config YAML.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 12, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread go.mod Outdated
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this will cause problems too, but as discussed in the other thread, I'm not sure how to avoid it.

@wking
Copy link
Copy Markdown
Member Author

wking commented Sep 12, 2024

/hold We want this to merge after openshift/cluster-version-operator#1087, to avoid accepting capability set strings in install-config validation that the Kube API server will later reject in ClusterVersion validation

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
Catching up with [1], and a backport-ish of 9d1f82a8ec (vendor: Update
openshift/api to pick up v4.17 and v4.18 capability sets, 2024-09-12, openshift#9002).
Generated with:

  $ GOPROXY=direct go get github.com/openshift/api@release-4.17
  $ go mod tidy
  $ go mod vendor
  $ go generate ./pkg/types/installconfig.go
  $ git add -A go.* vendor data/data/install.openshift.io_installconfigs.yaml

all using:

  $ go version
  go version go1.23.1 linux/amd64

where GOPROXY=direct avoids a caching delay [2]:

  I committed a new change (or released a new version) to a
  repository, why isn't it showing up when I run go get -u or go list
  -m --versions?

  In order to improve our services' caching and serving latencies, new
  versions may not show up right away. If you want new code to be
  immediately available in the mirror, then first make sure there is a
  semantically versioned tag for this revision in the underlying
  source repository. Then explicitly request that version via go get
  module@version. The new version should be available within one
  minute. Note that if someone requested the version before the tag
  was pushed, it may take up to 30 minutes for the mirror's cache to
  expire and fresh data about the version to become available. If the
  version is still not available after 30 minutes, please file an
  issue.

This will allow users to use the new capability sets in their install-config YAML.

[1]: openshift/api#2023
[2]: https://proxy.golang.org/
@wking wking force-pushed the release-4.17-v4.17-capability-set branch from f58596a to 899467f Compare September 13, 2024 21:21
@wking wking changed the base branch from master to release-4.17 September 13, 2024 21:22
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@wking: This pull request references Jira Issue OCPBUGS-41642, which is invalid:

  • expected dependent Jira Issue OCPBUGS-41111 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Catching up with openshift/api/pull/2023, and a backport-ish of 9d1f82a8ec (#9002). Generated with:

$ GOPROXY=direct go get github.com/openshift/api@release-4.17
$ go mod tidy
$ go mod vendor
$ go generate ./pkg/types/installconfig.go
$ git add -A go.* vendor data/data/install.openshift.io_installconfigs.yaml

all using:

$ go version
go version go1.22.2 linux/amd64

where GOPROXY=direct avoids a caching delay:

I committed a new change (or released a new version) to a repository, why isn't it showing up when I run go get -u or go list -m --versions?

In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute. Note that if someone requested the version before the tag was pushed, it may take up to 30 minutes for the mirror's cache to expire and fresh data about the version to become available. If the version is still not available after 30 minutes, please file an issue.

This will allow users to use the new capability sets in their install-config YAML.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
@wking
Copy link
Copy Markdown
Member Author

wking commented Sep 13, 2024

/skip

@wking
Copy link
Copy Markdown
Member Author

wking commented Sep 13, 2024

I think Prow won't recover from me accidentally openning with master as a base, even though I've adjusted that since. I'll open a new pull...

@wking wking closed this Sep 13, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@wking: This pull request references Jira Issue OCPBUGS-41642. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Catching up with openshift/api/pull/2023, and a backport-ish of 9d1f82a8ec (#9002). Generated with:

$ GOPROXY=direct go get github.com/openshift/api@release-4.17
$ go mod tidy
$ go mod vendor
$ go generate ./pkg/types/installconfig.go
$ git add -A go.* vendor data/data/install.openshift.io_installconfigs.yaml

all using:

$ go version
go version go1.23.1 linux/amd64

where GOPROXY=direct avoids a caching delay:

I committed a new change (or released a new version) to a repository, why isn't it showing up when I run go get -u or go list -m --versions?

In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute. Note that if someone requested the version before the tag was pushed, it may take up to 30 minutes for the mirror's cache to expire and fresh data about the version to become available. If the version is still not available after 30 minutes, please file an issue.

This will allow users to use the new capability sets in their install-config YAML.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2024

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/golint 899467f link true /test golint
ci/prow/openstack-manifests 899467f link true /test openstack-manifests
ci/prow/yaml-lint 899467f link true /test yaml-lint
ci/prow/artifacts-images 899467f link true /test artifacts-images
ci/prow/e2e-vsphere-ovn 899467f link true /test e2e-vsphere-ovn
ci/prow/e2e-agent-sno-ipv6 899467f link false /test e2e-agent-sno-ipv6
ci/prow/e2e-vsphere-ovn-upi 899467f link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-ovn-public-subnets 899467f link false /test e2e-aws-ovn-public-subnets
ci/prow/okd-unit 899467f link true /test okd-unit
ci/prow/e2e-vsphere-ovn-techpreview 899467f link false /test e2e-vsphere-ovn-techpreview
ci/prow/e2e-aws-ovn-single-node 899467f link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn 899467f link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation 899467f link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/e2e-metal-assisted 899467f link false /test e2e-metal-assisted
ci/prow/terraform-images 899467f link true /test terraform-images
ci/prow/e2e-vsphere-ovn-zones 899467f link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-metal-ipi-ovn-virtualmedia 899467f link false /test e2e-metal-ipi-ovn-virtualmedia
ci/prow/e2e-gcp-ovn-byo-vpc 899467f link false /test e2e-gcp-ovn-byo-vpc
ci/prow/images 899467f link true /test images
ci/prow/e2e-agent-compact-ipv4-none-platform 899467f link false /test e2e-agent-compact-ipv4-none-platform
ci/prow/e2e-nutanix-ovn 899467f link false /test e2e-nutanix-ovn
ci/prow/e2e-agent-sno-ipv4-pxe 899467f link false /test e2e-agent-sno-ipv4-pxe
ci/prow/aro-unit 899467f link true /test aro-unit
ci/prow/e2e-gcp-secureboot 899467f link false /test e2e-gcp-secureboot
ci/prow/okd-e2e-agent-compact-ipv4 899467f link false /test okd-e2e-agent-compact-ipv4
ci/prow/e2e-aws-ovn-imdsv2 899467f link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-gcp-ovn 899467f link true /test e2e-gcp-ovn
ci/prow/e2e-agent-compact-ipv4 899467f link true /test e2e-agent-compact-ipv4
ci/prow/okd-verify-codegen 899467f link true /test okd-verify-codegen
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage 899467f link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/e2e-agent-compact-ipv4-add-nodes 899467f link false /test e2e-agent-compact-ipv4-add-nodes
ci/prow/e2e-external-aws-ccm 899467f link false /test e2e-external-aws-ccm
ci/prow/e2e-metal-ipi-ovn-dualstack 899467f link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/govet 899467f link true /test govet
ci/prow/e2e-vsphere-ovn-zones-techpreview 899467f link false /test e2e-vsphere-ovn-zones-techpreview
ci/prow/e2e-azure-ovn-shared-vpc 899467f link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azurestack 899467f link false /test e2e-azurestack
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones 899467f link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-gcp-ovn-xpn 899467f link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-agent-ha-dualstack 899467f link false /test e2e-agent-ha-dualstack
ci/prow/altinfra-e2e-aws-ovn 899467f link false /test altinfra-e2e-aws-ovn
ci/prow/shellcheck 899467f link true /test shellcheck
ci/prow/azure-ovn-marketplace-images 899467f link false /test azure-ovn-marketplace-images
ci/prow/e2e-vsphere-ovn-upi-zones 899467f link false /test e2e-vsphere-ovn-upi-zones
ci/prow/unit 899467f link true /test unit
ci/prow/e2e-aws-ovn-fips 899467f link false /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups 899467f link false /test e2e-aws-ovn-shared-vpc-custom-security-groups
ci/prow/e2e-azure-ovn 899467f link true /test e2e-azure-ovn
ci/prow/e2e-openstack-proxy 899467f link false /test e2e-openstack-proxy
ci/prow/e2e-metal-ipi-ovn 899467f link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-edge-zones 899467f link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-heterogeneous 899467f link false /test e2e-aws-ovn-heterogeneous
ci/prow/altinfra-images 899467f link true /test altinfra-images
ci/prow/verify-codegen 899467f link true /test verify-codegen
ci/prow/integration-tests 899467f link true /test integration-tests
ci/prow/e2e-aws-ovn-upi 899467f link true /test e2e-aws-ovn-upi
ci/prow/e2e-metal-ipi-ovn-ipv6 899467f link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wking
Copy link
Copy Markdown
Member Author

wking commented Sep 13, 2024

#9013 avoids the Prow vs. base branch confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants