OCPBUGS-41111: vendor: Update openshift/api to pick up v4.17 and v4.18 capability sets#9002
OCPBUGS-41111: vendor: Update openshift/api to pick up v4.17 and v4.18 capability sets#9002wking wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@wking: This pull request references Jira Issue OCPBUGS-31111, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wking: This pull request references Jira Issue OCPBUGS-41111, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
9d1f82a to
df2b317
Compare
Catching up with [1]. Generated with: $ go get github.com/openshift/api@master $ go mod tidy $ go mod vendor $ go generate ./pkg/types/installconfig.go $ git add -A go.* vendor data/data/install.openshift.io_installconfigs.yaml all using: $ go version go version go1.23.1 linux/amd64 This will allow users to use the new capability sets in their install-config YAML. [1]: openshift/api#2022
df2b317 to
d8fe2d1
Compare
Catching up with [1], and a backport-ish of 9d1f82a8ec (vendor: Update openshift/api to pick up v4.17 and v4.18 capability sets, 2024-09-12, openshift#9002). Generated with: $ GOPROXY=direct go get github.com/openshift/api@release-4.17 $ go mod tidy $ go mod vendor $ go generate ./pkg/types/installconfig.go $ git add -A go.* vendor data/data/install.openshift.io_installconfigs.yaml all using: $ go version go version go1.23.1 linux/amd64 where GOPROXY=direct avoids a caching delay [2]: I committed a new change (or released a new version) to a repository, why isn't it showing up when I run go get -u or go list -m --versions? In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute. Note that if someone requested the version before the tag was pushed, it may take up to 30 minutes for the mirror's cache to expire and fresh data about the version to become available. If the version is still not available after 30 minutes, please file an issue. This will allow users to use the new capability sets in their install-config YAML. [1]: openshift/api#2023 [2]: https://proxy.golang.org/
|
//build 4.18.0-0.nightly-2024-09-13-024933, #9002 pre-merge verify pass, cc @jinyunma to confirm if any more test needed from installer side, thanks. |
|
Thanks @jiajliu , the pre-merge tests you did should be enough from installer perspective. |
|
/label qe-approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@wking: This pull request references Jira Issue OCPBUGS-41111. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Catching up with [1], and a backport-ish of 9d1f82a8ec (vendor: Update openshift/api to pick up v4.17 and v4.18 capability sets, 2024-09-12, openshift#9002). Generated with: $ GOPROXY=direct go get github.com/openshift/api@release-4.17 $ go mod tidy $ go mod vendor $ go generate ./pkg/types/installconfig.go $ git add -A go.* vendor data/data/install.openshift.io_installconfigs.yaml all using: $ go version go version go1.23.1 linux/amd64 where GOPROXY=direct avoids a caching delay [2]: I committed a new change (or released a new version) to a repository, why isn't it showing up when I run go get -u or go list -m --versions? In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute. Note that if someone requested the version before the tag was pushed, it may take up to 30 minutes for the mirror's cache to expire and fresh data about the version to become available. If the version is still not available after 30 minutes, please file an issue. This will allow users to use the new capability sets in their install-config YAML. [1]: openshift/api#2023 [2]: https://proxy.golang.org/
Catching up with openshift/api#2022. Generated with:
all using:
This will allow users to use the new capability sets in their install-config YAML.