Skip to content

NO-ISSUE: docs/dev/dependencies: Mention install-config YAML generation#9014

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
wking:doc-install-config-generate-step
Sep 16, 2024
Merged

NO-ISSUE: docs/dev/dependencies: Mention install-config YAML generation#9014
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
wking:doc-install-config-generate-step

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Sep 13, 2024

Catching up with c1dbb13 (#3515), to make it easier for first-time or occasional contributors to figure out how to update that file, after I had some trouble figuring this step out in #9002.

Catching up with c1dbb13 (pkg/types: ensure kubebuilder can build
correct documentation, 2020-04-27, openshift#3515), to make it easier for
first-time or occasional contributors to figure out how to update that
file.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 13, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@wking: This pull request explicitly references no jira issue.

Details

In response to this:

Catching up with c1dbb13 (#3515), to make it easier for first-time or occasional contributors to figure out how to update that file, after I had some trouble figuring this step out in #9002.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2024

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Copy Markdown
Contributor

The existing docs are in https://github.com/openshift/installer/blob/master/docs/dev/explain.md. If you know to look there, you probably don't need to be told :D

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit a43a015 into openshift:master Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants