Skip to content

AGENT-537: Add agent command to generate certificates#9557

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bfournie:agent-create-certs
Mar 18, 2025
Merged

AGENT-537: Add agent command to generate certificates#9557
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
bfournie:agent-create-certs

Conversation

@bfournie
Copy link
Copy Markdown
Contributor

@bfournie bfournie commented Mar 12, 2025 •
edited
Loading

Add a new hidden agent-based-installer command to generate tls certificates. This will be used by the agent UI.

$ ./bin/openshift-install agent create certificates
INFO Certificates created in: tls 
$ ls tls
admin-kubeconfig-signer.crt  kube-apiserver-lb-signer.crt  kube-apiserver-localhost-signer.crt  kube-apiserver-service-network-signer.crt
admin-kubeconfig-signer.key  kube-apiserver-lb-signer.key  kube-apiserver-localhost-signer.key  kube-apiserver-service-network-signer.key

@bfournie
AGENT-537: Add agent command to generate certificates
8a5e7a0 
Add a new hidden agent-based-installer command to generate tls
certificates. This will be used by the agent UI.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 12, 2025 •
edited by openshift-ci Bot
Loading

@bfournie: This pull request references AGENT-537 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Add a new hidden agent-based-installer command to generate tls certificates. This will be used by the agent UI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 12, 2025 •
edited by openshift-ci Bot
Loading

@bfournie: This pull request references AGENT-537 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Add a new hidden agent-based-installer command to generate tls certificates. This will be used by the agent UI.

$ ./bin/openshift-install agent create certificates
INFO Certificates created in: tls 
$ ls tls
admin-kubeconfig-signer.crt  kube-apiserver-lb-signer.crt  kube-apiserver-localhost-signer.crt  kube-apiserver-service-network-signer.crt
admin-kubeconfig-signer.key  kube-apiserver-lb-signer.key  kube-apiserver-localhost-signer.key  kube-apiserver-service-network-signer.key

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 12, 2025

/cc @andfasano @zaneb

@openshift-ci openshift-ci Bot requested review from andfasano, rna-afk, rwsu and zaneb March 12, 2025 17:01
@zaneb
Copy link
Copy Markdown
Member

zaneb commented Mar 12, 2025

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 12, 2025

/retest

tthvo
tthvo reviewed Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 14, 2025

/retest-required

Remaining retests: 0 against base HEAD bbf4e8c and 2 for PR HEAD 8a5e7a0 in total

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 14, 2025

/retest-required

Remaining retests: 0 against base HEAD bbf4e8c and 2 for PR HEAD 8a5e7a0 in total

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 14, 2025

/override ci/prow/okd-scos-images

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 14, 2025

@bfournie: Overrode contexts on behalf of bfournie: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 14, 2025

/retest-required

Remaining retests: 0 against base HEAD 73b3903 and 2 for PR HEAD 8a5e7a0 in total

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 14, 2025

/retest-required

Remaining retests: 0 against base HEAD 73b3903 and 2 for PR HEAD 8a5e7a0 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 15, 2025

/retest-required

Remaining retests: 0 against base HEAD 2cd2c7d and 1 for PR HEAD 8a5e7a0 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 15, 2025

/retest-required

Remaining retests: 0 against base HEAD 2cd55db and 2 for PR HEAD 8a5e7a0 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 15, 2025

/retest-required

Remaining retests: 0 against base HEAD 74c0c30 and 1 for PR HEAD 8a5e7a0 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 16, 2025

/retest-required

Remaining retests: 0 against base HEAD 74c0c30 and 2 for PR HEAD 8a5e7a0 in total

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 17, 2025

/override ci/prow/okd-scos-images

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 17, 2025

@bfournie: Overrode contexts on behalf of bfournie: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 17, 2025 •
edited
Loading

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage 8a5e7a0 link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/okd-scos-e2e-aws-ovn 8a5e7a0 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 17, 2025

/override ci/prow/aro-unit

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 17, 2025

/override ci/prow/integration-tests-nodejoiner

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 17, 2025

/retest-required

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 17, 2025

/retest

@bfournie bfournie mentioned this pull request Mar 17, 2025
Merged
@andfasano
Copy link
Copy Markdown
Contributor

andfasano commented Mar 18, 2025

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 18, 2025 •
edited by openshift-ci Bot
Loading

@andfasano: This pull request references AGENT-537 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 18, 2025

/test aro-unit

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 18, 2025

@bfournie: No presubmit jobs available for openshift/installer@main

Details

In response to this:

/test aro-unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Mar 18, 2025

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 18, 2025

/retest-required

Remaining retests: 0 against base HEAD 74c0c30 and 2 for PR HEAD 8a5e7a0 in total

@openshift-merge-bot openshift-merge-bot Bot merged commit c74674d into openshift:main Mar 18, 2025
17 checks passed
@bfournie bfournie deleted the agent-create-certs branch March 18, 2025 20:00
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 19, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.19.0-202503182309.p0.gc74674d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 19, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202503182309.p0.gc74674d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 19, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.19.0-202503182309.p0.gc74674d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 19, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.19.0-202503182309.p0.gc74674d.assembly.stream.el9.
All builds following this will include this PR.

@hasbro17 hasbro17 mentioned this pull request Apr 16, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@zaneb zaneb Awaiting requested review from zaneb

@rna-afk rna-afk Awaiting requested review from rna-afk

@rwsu rwsu Awaiting requested review from rwsu

1 more reviewer

@tthvo tthvo tthvo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tthvo tthvo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bfournie @openshift-ci-robot @zaneb @andfasano @openshift-bot @tthvo