AGENT-537: Run agent installer command to create certificates#9574
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@bfournie: This pull request references AGENT-537 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
bfournie
force-pushed
the
agent-create-certs-service
branch
from
c042148 to
bf8c7ac
Compare
openshift-ci
Bot
added
the
approved
If the agent tls certificates have not been created yet, i.e. when using the agent UI, use the installer command to create the certs prior to running the assisted-service.
bfournie
force-pushed
the
agent-create-certs-service
branch
from
bf8c7ac to
36ca6ca
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| # This allows the certs to be created at run-time, e.g. when installed via the UI | ||
| AGENT_TLS_DIR=/opt/agent/tls | ||
| if [ -z $(ls -A "$AGENT_TLS_DIR") ]; then | ||
| . /usr/local/bin/release-image.sh |
There was a problem hiding this comment.
It could be worth echoing a message, to leave a trace in the journal that the certs have been lazily generated (for troubleshooting)
There was a problem hiding this comment.
Presumably the installer will log something.
| # This allows the certs to be created at run-time, e.g. when installed via the UI | ||
| AGENT_TLS_DIR=/opt/agent/tls | ||
| if [ -z $(ls -A "$AGENT_TLS_DIR") ]; then | ||
| . /usr/local/bin/release-image.sh |
There was a problem hiding this comment.
Presumably the installer will log something.
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/okd-scos-images |
|
/retest-required |
|
@bfournie: Overrode contexts on behalf of bfournie: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label acknowledge-critical-fixes-only |
openshift-ci
Bot
added
the
acknowledge-critical-fixes-only
|
/override ci/prow/okd-scos-images |
|
@bfournie: Overrode contexts on behalf of bfournie: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
Bot
merged commit 5a7e9bf
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
5 participants
If the agent tls certificates have not been created yet, i.e. when using the agent UI, use the installer command to create the certs prior to running the assisted-service.
Requires #9557