Skip to content

AGENT-537: Run agent installer command to create certificates #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Mar 22, 2025
Merged

AGENT-537: Run agent installer command to create certificates #9574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions data/data/agent/files/usr/local/bin/set-node-zero.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ done
if [ "${IS_NODE_ZERO}" = "true" ]; then
echo "Node 0 IP ${NODE_ZERO_IP} found on this host" 1>&2

# Create tls certs, if they don't exist, via the installer command.
# This allows the certs to be created at run-time, e.g. when installed via the UI
AGENT_TLS_DIR=/opt/agent/tls
if [ -z $(ls -A "$AGENT_TLS_DIR") ]; then
. /usr/local/bin/release-image.sh
Copy link
Copy Markdown
Contributor

@andfasano andfasano Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be worth echoing a message, to leave a trace in the journal that the certs have been lazily generated (for troubleshooting)

Copy link
Copy Markdown
Member

@zaneb zaneb Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably the installer will log something.

IMAGE=$(image_for installer)
/usr/bin/podman run --privileged -v /tmp:/assets --rm "${IMAGE}" agent create certificates --dir=/assets
cp /tmp/tls/* $AGENT_TLS_DIR
fi

Comment thread
bfournie marked this conversation as resolved.
Outdated
NODE0_PATH=/etc/assisted/node0
mkdir -p "$(dirname "${NODE0_PATH}")"

Expand Down