CORS-4067: Add support for single zone NAT gateway #9753
Conversation
|
@rna-afk: This pull request references CORS-4067 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
patrickdillon
left a comment
patrickdillon
left a comment
There was a problem hiding this comment.
At a high level, this looks good. I do think we need to work out the install config API questions before moving forward ( see my comment in the PR)
It would be good to include some testing results and also it should be pretty simple to add pre-submit tests for this functionality so we can test this PR in CI. Happy to collaborate on that.
pkg/infrastructure/azure/azure.go
Outdated
|
|
||
| var loadBalancer *armnetwork.LoadBalancer | ||
| if platform.OutboundType == aztypes.UserDefinedRoutingOutboundType { | ||
| if platform.OutboundType != aztypes.LoadbalancerOutboundType { |
There was a problem hiding this comment.
Is this correct? For NATGateway our current thinking is that control plane nodes will still use the API load balancer for outbound access, so I'm not certain we want this change.
rna-afk
force-pushed
the
azure_single_nat_gateway
branch
from
9e12d62 to
f53184a
Compare
rna-afk
force-pushed
the
azure_single_nat_gateway
branch
from
f53184a to
a6d0b46
Compare
patrickdillon
left a comment
patrickdillon
left a comment
There was a problem hiding this comment.
There are a few more annotations that need to be fixed:
installer/pkg/types/azure/platform.go
Line 12 in 4bec6f4
https://github.com/openshift/installer/blob/main/pkg/types/azure/platform.go#L79
For that last one, it would be good to include details about the NAT Gateway (repeating the comment text for the constant would be fine), because I believe those are the details included in the explain text.
And then the crd would need to be regenerated with go generate ./pkg/types/installconfig.go
rna-afk
force-pushed
the
azure_single_nat_gateway
branch
2 times, most recently
from
46800f2 to
389f8a5
Compare
|
I'm coming in late here, but this LGTM ;-) |
rna-afk
force-pushed
the
azure_single_nat_gateway
branch
6 times, most recently
from
1cfe907 to
053a182
Compare
patrickdillon
left a comment
patrickdillon
left a comment
There was a problem hiding this comment.
Let's get openshift/release#65568 in (needs some slight changes) so we can test this PR.
rna-afk
force-pushed
the
azure_single_nat_gateway
branch
2 times, most recently
from
a8d5c70 to
85c1030
Compare
rna-afk
force-pushed
the
azure_single_nat_gateway
branch
from
85c1030 to
d9b77d5
Compare
|
/test ci/prow/e2e-azure-nat-gateway-single-zone |
|
@rna-afk: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-azure-nat-gateway-single-zone |
Adding the option for the users to create a NAT gateway for the compute nodes as an option to replace the traditional load balancer setup. This is only for a single NAT gateway in the compute subnet as CAPZ expects an outbound LB for control planes.
rna-afk
force-pushed
the
azure_single_nat_gateway
branch
from
d9b77d5 to
9ea9f83
Compare
|
/test e2e-azure-nat-gateway-single-zone |
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve shoot, I thought we merged this a while ago... I can tag in a moment, just going to do a final test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-merge-bot
bot
merged commit 569bbc8
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
7 participants
Adding the option for the users to create a NAT gateway for the compute nodes as an option to replace the traditional load balancer setup. This is only for a single NAT gateway in the compute subnet as CAPZ expects an outbound LB for control planes.