Skip to content

CORS-4069: Add test for nat gateway support #65568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jul 2, 2025
Merged

CORS-4069: Add test for nat gateway support #65568

openshift-merge-bot merged 1 commit into from
Jul 2, 2025

Conversation

@rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Jun 2, 2025

Adding CI test to set the install config outbound type to nat gateway to test nat gateway support.

@rna-afk rna-afk changed the title azure: Add test for nat gateway support CORS-4069: Add test for nat gateway support Jun 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 2, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 2, 2025 •
edited by openshift-ci bot
Loading

@rna-afk: This pull request references CORS-4069 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Adding CI test to set the install config outbound type to nat gateway to test nat gateway support.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from barbacbd and smg247 June 2, 2025 19:03
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 2, 2025

@rna-afk, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo114799347/ci-operator/step-registry/ipi/conf/azure/nat-gateway/ipi-conf-azure-natgateway-commands.sh has incorrect prefix. Prefix should be ipi-conf-azure-nat-gateway
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rna-afk rna-afk force-pushed the azure_single_nat_gateway branch from a9ec1b2 to 029661b Compare June 2, 2025 19:28
@barbacbd
Copy link
Contributor

barbacbd commented Jun 2, 2025

/cc @jhixson74

@openshift-ci openshift-ci bot requested a review from jhixson74 June 2, 2025 19:58
barbacbd
barbacbd reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@barbacbd
Copy link
Contributor

barbacbd commented Jun 2, 2025

Looks like make ci-operator-config may solve the test issue above @rna-afk.

@rna-afk rna-afk force-pushed the azure_single_nat_gateway branch from 029661b to b333f7a Compare June 4, 2025 15:22
@patrickdillon
Copy link
Contributor

patrickdillon commented Jun 4, 2025

Need to run make jobs and recommit the generated job.

@rna-afk rna-afk force-pushed the azure_single_nat_gateway branch 2 times, most recently from 7f58763 to 884ecf3 Compare June 4, 2025 20:59
jinyunma
jinyunma reviewed Jun 5, 2025
View reviewed changes
@patrickdillon
Copy link
Contributor

patrickdillon commented Jun 10, 2025

/pj-rehearse pull-ci-openshift-installer-main-e2e-azure-nat-gateway-single-zone

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 10, 2025

@patrickdillon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@patrickdillon patrickdillon mentioned this pull request Jun 10, 2025
Merged
@rna-afk rna-afk force-pushed the azure_single_nat_gateway branch from 884ecf3 to c61610f Compare June 10, 2025 22:24
@patrickdillon
Copy link
Contributor

patrickdillon commented Jun 16, 2025

/approve
/lgtm
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2025

@patrickdillon: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 16, 2025
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2025

/retest-required

Remaining retests: 0 against base HEAD 33ed1e0 and 2 for PR HEAD c61610f in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2025

/retest-required

Remaining retests: 0 against base HEAD 7331cd9 and 1 for PR HEAD c61610f in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2025

/retest-required

Remaining retests: 0 against base HEAD f359799 and 0 for PR HEAD c61610f in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2025 •
edited
Loading

@rna-afk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/main/e2e-azure-nat-gateway-single-zone 884ecf3 link unknown /pj-rehearse pull-ci-openshift-installer-main-e2e-azure-nat-gateway-single-zone

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 17, 2025

/hold

Revision c61610f was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2025
@rna-afk
azure: Add test for nat gateway support
3fb517b 
Adding CI test to set the install config outbound type
to nat gateway to test nat gateway support.
@rna-afk rna-afk force-pushed the azure_single_nat_gateway branch from c61610f to 3fb517b Compare June 17, 2025 14:59
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 17, 2025

[REHEARSALNOTIFIER]
@rna-afk: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-console-release-4.11-kubevirt-plugin openshift/console presubmit Registry content changed
pull-ci-openshift-console-release-4.10-kubevirt-plugin openshift/console presubmit Registry content changed
pull-ci-openshift-console-release-4.9-kubevirt-plugin openshift/console presubmit Registry content changed
pull-ci-openshift-console-release-4.8-kubevirt-plugin openshift/console presubmit Registry content changed
pull-ci-openshift-console-release-4.7-kubevirt-plugin openshift/console presubmit Registry content changed
pull-ci-openshift-console-operator-main-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.21-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.20-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.19-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.18-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.17-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.16-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.15-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.14-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.13-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.12-e2e-azure-ovn-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.11-e2e-agnostic-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.10-e2e-agnostic-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.9-e2e-agnostic-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.8-e2e-agnostic-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-console-operator-release-4.7-e2e-agnostic-upgrade openshift/console-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.21-e2e-azure-operator openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.20-e2e-azure-operator openshift/cluster-ingress-operator presubmit Registry content changed
pull-ci-openshift-cluster-ingress-operator-release-4.19-e2e-azure-operator openshift/cluster-ingress-operator presubmit Registry content changed

A total of 3446 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rna-afk
Copy link
Contributor Author

rna-afk commented Jun 20, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2025
@jhixson74
Copy link
Member

jhixson74 commented Jul 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, jhixson74, patrickdillon, rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rna-afk
Copy link
Contributor Author

rna-afk commented Jul 2, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 2, 2025

@rna-afk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bfad26e into openshift:master Jul 2, 2025
17 checks passed
MrSanketkumar pushed a commit to MrSanketkumar/release that referenced this pull request Aug 1, 2025
@rna-afk @MrSanketkumar
azure: Add test for nat gateway support (openshift#65568)
3aa185f 
Adding CI test to set the install config outbound type
to nat gateway to test nat gateway support.
liweinan pushed a commit to liweinan/release that referenced this pull request Aug 5, 2025
@rna-afk @liweinan
azure: Add test for nat gateway support (openshift#65568)
e7d2ec8 
Adding CI test to set the install config outbound type
to nat gateway to test nat gateway support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smg247 smg247 Awaiting requested review from smg247

@jhixson74 jhixson74 Awaiting requested review from jhixson74

3 more reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@barbacbd barbacbd barbacbd left review comments

@jinyunma jinyunma jinyunma left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jhixson74 jhixson74

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rna-afk @openshift-ci-robot @barbacbd @patrickdillon @jhixson74 @jinyunma