Revert fix on openshift.run('jenkins-second-deployment')#336
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Jun 22, 2020
Merged
Revert fix on openshift.run('jenkins-second-deployment')#336openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
approved
gabemontero
reviewed
Jun 22, 2020
| @@ -289,14 +289,14 @@ void actualTest() {*/ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
are we sure lines 275 to 288 still work @akram ? what are the details on what you've tested ?
Contributor
|
OK @akram tells me on slack that manual verification of this file passes /lgtm after this merges I'll initiate some e2e-gcp-builds runs in openshift/origin#25171 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akram, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.