[release-4.3] [release-4.4] Bug 1848976: reenable jenkins e2e in e2e-gcp-builds

[openshift-cherrypick-robot]

This is an automated cherry-pick of #25128

/assign gabemontero

[openshift-ci-robot]

@openshift-cherrypick-robot: Bugzilla bug 1847551 has been cloned as Bugzilla bug 1848976. Retitling PR to link against new bug.
/retitle [release-4.3] [release-4.4] Bug 1848976: reenable jenkins e2e in e2e-gcp-builds

Details

In response to this:

[release-4.3] [release-4.4] Bug 1847551: reenable jenkins e2e in e2e-gcp-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1848976, which is invalid:

• expected dependent Bugzilla bug 1847551 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] [release-4.4] Bug 1848976: reenable jenkins e2e in e2e-gcp-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

@akram @waveywaves @adambkaplan @bparees FYI

the 4.3 version of sorting out jenkins e2e after post JDK fix re-enablement in latest release

[gabemontero]

/approve

[gabemontero]

/lgtm

I'll mark the 4.4 bug verified once ART bots move to on qa

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/builds/OWNERS [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gabemontero]

/test images

[gabemontero]

jenkins e2e passing in https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/25171/pull-ci-openshift-origin-release-4.3-e2e-gcp-builds/1273955811843903488

@adambkaplan @akram

[openshift-bot]

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

[openshift-ci-robot]

@openshift-bot: This pull request references Bugzilla bug 1848976, which is invalid:

• expected dependent Bugzilla bug 1847551 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/bugzilla refresh

[openshift-ci-robot]

@gabemontero: This pull request references Bugzilla bug 1848976, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.3.z) matches configured target release for branch (4.3.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1847551 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1847551 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
• bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

So a couple of points on this prior attempt to get jenkins e2e working in 4.3.z @bparees @akram

• ultimately, this will get superceded by 4.3 cherrypick of Bug 1850109: remove problematic upstream client plugin test #25179

• you see e2e-gcp-builds passed with https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/25171/pull-ci-openshift-origin-release-4.3-e2e-gcp-builds/1273955811843903488 which undoubtedly ran before @akram merged openshift/jenkins-client-plugin@64f5e29#diff-12449f539d84717c248cfd4ab524c9cf and openshift/jenkins-client-plugin@d36a921#diff-12449f539d84717c248cfd4ab524c9cf

• another short term work around is to revert those commits in https://github.com/openshift/jenkins-client-plugin and see if e2e-gcp-builds still passes in this PR

• long term, again, the answer is a 25179 cherrypick back to as many earlier releases as needed, and complete the openshift/release work around Bug 1847421: move openshift/origin using examples/jenkins-image-sample.groovy into repo jenkins-client-plugin#335 ... and then in the future, continue to use the replacement of https://github.com/openshift/jenkins-client-plugin/blob/master/examples/jenkins-image-sample.groovy in those new e2e's

[gabemontero]

ok @akram and I have been chatting, and he is going to revert those 2 commits I mentioned.

I'll then re-run e2e-gcp-builds test, make sure it still passes.

If it does, then, @bparees, since this is test case only, can you cherry pick approve this and get it to merged?

I ask because as part of 4.2 EOL, ART is asking for one more fix from @akram to get in for a customer case (it is in an unrelated template) ... but he says 4.2 is now failing the same way the newer releases. So most likely we'll need to pick this back as well. And that will be much faster than picking back #25179 all the way to 4.2.

Lastly, if anyone is curious on the oc/cli changes which apparently have lead to all this churn, reach out to @akram separately.

[bparees]

I ask because as part of 4.2 EOL, ART is asking for one more fix from @akram to get in for a customer case (it is in an unrelated template)

if ART is asking for a 4.2 respin today, then yes i can merge this. @vikaslaad can you confirm we're good to merge this into 4.2.z to unblock the other merge into 4.2.z?

[vikaslaad]

Yes, we can rebuild 4.2 today. Please merge it

[gabemontero]

FYI @akram 's PR to revert the upstream testcase is openshift/jenkins-client-plugin#336

[bparees]

approved, retest the other 4.2 PR as needed once this merges.

[gabemontero]

/hold

[gabemontero]

will unhold once we get and e2e-gcp-builds test pass after openshift/jenkins-client-plugin#336 merges

[gabemontero]

OK I believe the current e2e-gcp-builds job was started before openshift/jenkins-client-plugin#336 merged.

We will have to interrogate it to see if it picked up the upstream changes before unholding this PR.

If need be, I'll issue another e2e-gcp-builds run before unholding @akram @bparees @vikaslaad

Then, once this merges, I'll cherrypick back to 4.2.

[akram]

looks like the e2e-gcp build failed, but not because of the jenkins-client-plugin

/test e2e-gcp

[gabemontero]

Ok the client plugin test in e2e-gcp-builds passed in https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/25171/pull-ci-openshift-origin-release-4.3-e2e-gcp-builds/1275082307065090048:

[Feature:Builds][Feature:Jenkins][Slow] openshift pipeline build jenkins-client-plugin tests using the ephemeral template [Suite:openshift] | 8m0s

the failure was an unrelated buildah conformance test

/unhold

[gabemontero]

/test e2e-gcp-builds

/cherrypick release-4.2

[openshift-cherrypick-robot]

@gabemontero: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you.

Details

In response to this:

/test e2e-gcp-builds

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[akram]

good news

[openshift-ci-robot]

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/origin#25171. Bugzilla bug 1848976 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] [release-4.4] Bug 1848976: reenable jenkins e2e in e2e-gcp-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@gabemontero: new pull request created: #25183

Details

In response to this:

/test e2e-gcp-builds

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.