Skip to content

Bug 1850109: remove problematic upstream client plugin test#25179

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
gabemontero:mv-e2e-bld-off-client-plugin-sample
Jun 24, 2020
Merged

Bug 1850109: remove problematic upstream client plugin test#25179
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
gabemontero:mv-e2e-bld-off-client-plugin-sample

Conversation

@gabemontero
Copy link
Copy Markdown
Contributor

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2020
@gabemontero
Copy link
Copy Markdown
Contributor Author

@bparees the e2e-gcp-builds passed with just my removal of the problematic portion in https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/25179/pull-ci-openshift-origin-master-e2e-gcp-builds/1274727599406321664

if you search the successful tests you'll see

[sig-builds][Feature:Builds][sig-devex][Feature:Jenkins][Slow] openshift pipeline build jenkins-client-plugin tests using the ephemeral template [Suite:openshift] | 3m49s

with a non trivial time ... it ran

As I said in the other PR, of course this can merge after your skip PR as needed

@gabemontero
Copy link
Copy Markdown
Contributor Author

/retest

@gabemontero gabemontero force-pushed the mv-e2e-bld-off-client-plugin-sample branch from 7363d8b to 5afc372 Compare June 21, 2020 22:39
@gabemontero
Copy link
Copy Markdown
Contributor Author

another passing jenkins client plugin test with it re-enabled after Ben's PR merge

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/25179/pull-ci-openshift-origin-master-e2e-gcp-builds/1274834458737905664

[sig-builds][Feature:Builds][sig-devex][Feature:Jenkins][Slow] openshift pipeline build jenkins-client-plugin tests using the ephemeral template [Suite:openshift] | 3m27s

@gabemontero
Copy link
Copy Markdown
Contributor Author

/retest

@bparees
Copy link
Copy Markdown
Contributor

bparees commented Jun 22, 2020

lgtm but will let @akram sign off since it's disabling a test(that i understand is re-enabled by your other PR, i just don't want this going in w/o @akram and team understanding the relationship and being ok w/ the changes)

@akram
Copy link
Copy Markdown
Contributor

akram commented Jun 22, 2020

/test e2e-cmd

@gabemontero
Copy link
Copy Markdown
Contributor Author

lgtm but will let @akram sign off since it's disabling a test(that i understand is re-enabled by your other PR, i just don't want this going in w/o @akram and team understanding the relationship and being ok w/ the changes)

agreed @bparees @akram

@gabemontero
Copy link
Copy Markdown
Contributor Author

install cluster flake in e2e-cmd

/retest

@gabemontero
Copy link
Copy Markdown
Contributor Author

/assign @akram

With openshift/jenkins-client-plugin#338 I've proven both successful and failed test job run in the jenkins-client-plugin repo ... basically that is the replacement from the build e2e test I've removed here

Your team should take over that e2e and grow it as you all deem appropriate.

if you agree, go ahead and lgtm

/retes

@gabemontero
Copy link
Copy Markdown
Contributor Author

/retest

@gabemontero gabemontero changed the title remove problematic upstream client plugin test Bug 1850109: remove problematic upstream client plugin test Jun 23, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: This pull request references Bugzilla bug 1850109, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1850109: remove problematic upstream client plugin test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 23, 2020
@gabemontero
Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: This pull request references Bugzilla bug 1850109, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akram
Copy link
Copy Markdown
Contributor

akram commented Jun 23, 2020

great work @gabemontero , that seems perfect, we will take over it and build on top

/test e2e-cmd
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ba54539 into openshift:master Jun 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: All pull requests linked via external trackers have merged: openshift/origin#25179. Bugzilla bug 1850109 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1850109: remove problematic upstream client plugin test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the mv-e2e-bld-off-client-plugin-sample branch June 24, 2020 11:52
@gabemontero
Copy link
Copy Markdown
Contributor Author

/cherrypick release-4.5

@openshift-cherrypick-robot
Copy link
Copy Markdown

@gabemontero: #25179 failed to apply on top of branch "release-4.5":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/extended/builds/pipeline_origin_bld.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/builds/pipeline_origin_bld.go
CONFLICT (content): Merge conflict in test/extended/builds/pipeline_origin_bld.go
Patch failed at 0001 remove problematic upstream client plugin test

Details

In response to this:

/cherrypick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants