Skip to content

Bug 1850493: remove problematic upstream client plugin test#25200

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.5from
gabemontero:mv-e2e-bld-off-client-plugin-sample-45
Jun 26, 2020
Merged

Bug 1850493: remove problematic upstream client plugin test#25200
openshift-merge-robot merged 1 commit intoopenshift:release-4.5from
gabemontero:mv-e2e-bld-off-client-plugin-sample-45

Conversation

@gabemontero
Copy link
Copy Markdown
Contributor

manual pick of #25179 since bot failed #25179 (comment)

@adambkaplan @akram @bparees FYI

@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

remove problematic upstream client plugin test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero changed the title remove problematic upstream client plugin test Bug 1850493: remove problematic upstream client plugin test Jun 24, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: This pull request references Bugzilla bug 1850493, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1850493: remove problematic upstream client plugin test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@gabemontero gabemontero force-pushed the mv-e2e-bld-off-client-plugin-sample-45 branch from a769e29 to a173858 Compare June 24, 2020 12:08
@gabemontero
Copy link
Copy Markdown
Contributor Author

/assign @akram

not going to change the BZ target to 4.5.0 just yet .... given the proximity to GA and the focus 4.5.0 bugs are getting, let's first get passing tests and a lgtm and then we can see if this is needed before 4.5.z or not.

Certainly @akram as long as we use the new e2e in client-plugin and nobody updates https://github.com/openshift/jenkins-client-plugin/blob/master/examples/jenkins-image-sample.groovy we should be OK to wait.

@gabemontero
Copy link
Copy Markdown
Contributor Author

client plugin test looks good @akram

[sig-builds][Feature:Builds][sig-devex][Feature:Jenkins][Slow] openshift pipeline build jenkins-client-plugin tests using the ephemeral template [Suite:openshift] | 4m52s

feel free to lgtm at your discretion

@gabemontero
Copy link
Copy Markdown
Contributor Author

/retest

@akram
Copy link
Copy Markdown
Contributor

akram commented Jun 24, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Copy Markdown

@openshift-bot: This pull request references Bugzilla bug 1850493, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 25, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: This pull request references Bugzilla bug 1850493, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1850109 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1850109 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 25, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f291db1 into openshift:release-4.5 Jun 26, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@gabemontero: All pull requests linked via external trackers have merged: openshift/origin#25200. Bugzilla bug 1850493 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1850493: remove problematic upstream client plugin test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the mv-e2e-bld-off-client-plugin-sample-45 branch June 26, 2020 13:21
@gabemontero
Copy link
Copy Markdown
Contributor Author

/cherrypick release-4.4

@openshift-cherrypick-robot
Copy link
Copy Markdown

@gabemontero: new pull request created: #25212

Details

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants