Adds unit test target in Makefile#27
Conversation
only builds binary in e2e tests
openshift-ci-robot
added
size/XS
|
/assign @rhuss |
rhuss
left a comment
rhuss
left a comment
There was a problem hiding this comment.
looks good to me, but maybe we can add check for the generated files, too ?
|
|
||
| build: | ||
| ./hack/build.sh | ||
| ./hack/build.sh -f |
There was a problem hiding this comment.
Maybe we should add somewhere a build.sh --codegen as this will do the formatting/doc gen/license check ?
Not sure whether this is the proper place.
There was a problem hiding this comment.
I expect this to happen upstream only, given the resource constraints in CI, I am hoping we do only two operations in OpenShift CI which are relevant
- build the binary
- Run e2e tests against openshift
thats it.
| .PHONY: build | ||
|
|
||
| test-unit: | ||
| go test -v ./pkg/... |
There was a problem hiding this comment.
good for now, but I can also add teh semantics of build.sh --test to run only tests when given alone.
There was a problem hiding this comment.
I was thinking same, we need a way only run tests.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
only builds binary in e2e tests