Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Adds unit test target in Makefile #27

Merged
openshift-merge-robot merged 1 commit into from
Jul 16, 2019
Merged

Adds unit test target in Makefile #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@ CGO_ENABLED=0
GOOS=linux

build:
./hack/build.sh
./hack/build.sh -f
Copy link
Copy Markdown

@rhuss rhuss Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add somewhere a build.sh --codegen as this will do the formatting/doc gen/license check ?

Not sure whether this is the proper place.

Copy link
Copy Markdown
Author

@navidshaikh navidshaikh Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this to happen upstream only, given the resource constraints in CI, I am hoping we do only two operations in OpenShift CI which are relevant

  1. build the binary
  2. Run e2e tests against openshift
    thats it.

.PHONY: build

test-unit:
go test -v ./pkg/...
Copy link
Copy Markdown

@rhuss rhuss Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for now, but I can also add teh semantics of build.sh --test to run only tests when given alone.

Copy link
Copy Markdown
Author

@navidshaikh navidshaikh Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking same, we need a way only run tests.

.PHONY: test-unit

test-e2e:
./openshift/e2e-tests-openshift.sh
.PHONY: test-e2e
Expand Down
2 changes: 1 addition & 1 deletion openshift/e2e-tests-openshift.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function create_test_namespace(){

function build_knative_client() {
failed=0
./hack/build.sh || failed=1
./hack/build.sh -f || failed=1
return $failed
}

Expand Down