Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

WIP: Release next test patch#1314

Closed
matzew wants to merge 4 commits into
openshift:release-nextfrom
matzew:release_next_test_patch
Closed

WIP: Release next test patch#1314
matzew wants to merge 4 commits into
openshift:release-nextfrom
matzew:release_next_test_patch

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Jun 14, 2021

Testing the webhook issue, like here: openshift/knative-serving#801

  • Cherry picked upstream fix
  • regenerated yaml for actual refernece/usage

alanfx and others added 4 commits June 13, 2021 20:34
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@openshift-ci openshift-ci Bot requested review from alanfx and lberk June 14, 2021 07:18
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2021
@matzew matzew changed the title Release next test patch WIP: Release next test patch Jun 14, 2021
@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 14, 2021
Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold

Feel free to unhold

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 14, 2021

we dont merge to release-next directly. this is more test.

release -next is created out of upstream main, and tthe main from here.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 14, 2021

@matzew: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/48-reconciler-aws-ocp-48 4ed7324 link /test 48-reconciler-aws-ocp-48

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alanfx alanfx force-pushed the release-next branch 2 times, most recently from bb4e8f1 to 942a612 Compare June 16, 2021 00:34
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Jun 16, 2021

/close

@openshift-ci openshift-ci Bot closed this Jun 16, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 16, 2021

@matzew: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants