Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

🤖 Triggering CI on branch 'release-next' after synching to upstream/main#801

Merged
alanfx merged 1 commit into
release-nextfrom
release-next-ci
Jun 17, 2021
Merged

🤖 Triggering CI on branch 'release-next' after synching to upstream/main#801
alanfx merged 1 commit into
release-nextfrom
release-next-ci

Conversation

@alanfx
Copy link
Copy Markdown

@alanfx alanfx commented Jun 11, 2021

No description provided.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanfx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2021
@alanfx alanfx force-pushed the release-next-ci branch from 20125f5 to 2b265ae Compare June 12, 2021 00:34
@alanfx alanfx force-pushed the release-next-ci branch from 2b265ae to 78a5371 Compare June 13, 2021 00:34
@nak3
Copy link
Copy Markdown

nak3 commented Jun 14, 2021

{"severity":"ERROR","timestamp":"2021-06-13T01:36:52.835343985Z","logger":"webhook.ValidationWebhook","caller":"controller/controller.go:549","message":"Reconcile error","knative.dev/pod":"webhook-7cbcc64694-vqkpg","duration":"15.068283ms","error":"failed to update webhook: validatingwebhookconfigurations.admissionregistration.k8s.io \"validation.webhook.serving.knative.dev\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\t/go/src/knative.dev/serving/vendor/knative.dev/pkg/controller/controller.go:549\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\t/go/src/knative.dev/serving/vendor/knative.dev/pkg/controller/controller.go:532\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\t/go/src/knative.dev/serving/vendor/knative.dev/pkg/controller/controller.go:468"}

It seems an error happens now.

@nak3
Copy link
Copy Markdown

nak3 commented Jun 14, 2021

knative/pkg#2098 added ownerRef to webhook so webhook needs RBAC.
One thing which is still not clear to me why upstream does not need the permission 🤔

@nak3
Copy link
Copy Markdown

nak3 commented Jun 16, 2021

/retest

infra issue.

@markusthoemmes
Copy link
Copy Markdown

/retest

Infra

@alanfx
Copy link
Copy Markdown
Author

alanfx commented Jun 17, 2021

OCF Webhook is merging this PR

@alanfx alanfx merged commit 045705c into release-next Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/sync-fork-to-upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants