Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[RELEASE-1.3] Bump version label in manifest#1136

Merged
openshift-merge-robot merged 1 commit into
openshift:release-v1.3from
nak3:bump-version-label
Jun 3, 2022
Merged

[RELEASE-1.3] Bump version label in manifest#1136
openshift-merge-robot merged 1 commit into
openshift:release-v1.3from
nak3:bump-version-label

Conversation

@nak3
Copy link
Copy Markdown

@nak3 nak3 commented Jun 3, 2022

@openshift-ci openshift-ci Bot requested review from mgencur and skonto June 3, 2022 12:08
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@nak3 nak3 changed the title Bump version label in manifest [RELEASE-1.3] Bump version label in manifest Jun 3, 2022
@skonto
Copy link
Copy Markdown

skonto commented Jun 3, 2022

Basically the error is:

{"severity":"INFO","timestamp":"2022-06-03T11:42:11.302716184Z","logger":"knative-operator.event-broadcaster","caller":"record/event.go:282","message":"Event(v1.ObjectReference{Kind:\"KnativeServing\", Namespace:\"knative-serving\", Name:\"knative-serving\", UID:\"daf5dbff-07ff-428d-93d1-fe2defd15220\", APIVersion:\"operator.knative.dev/v1alpha1\", ResourceVersion:\"38900\", FieldPath:\"\"}): type: 'Warning' reason: 'InternalError' the version of the manifests v1.2.0 of the component knative-serving does not match the target version of the operator CR v1.3.0","knative.dev/pod":"knative-operator-77fc486fd-q96wp"}

I thought we got rid of this compliance requirement.

@skonto
Copy link
Copy Markdown

skonto commented Jun 3, 2022

/lgtm

@skonto
Copy link
Copy Markdown

skonto commented Jun 3, 2022

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2022
@skonto
Copy link
Copy Markdown

skonto commented Jun 3, 2022

/retest

@skonto skonto added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
@skonto
Copy link
Copy Markdown

skonto commented Jun 3, 2022

Holding for CI

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 3, 2022

@nak3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3
Copy link
Copy Markdown
Author

nak3 commented Jun 3, 2022

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7e612b3 into openshift:release-v1.3 Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants