Fix minor script error for CI config#1134
Conversation
When creating openshift/release#29082, there are two errors found. - `make test-conformance` and `make test-reconciler` does not exist on serving. (I copied the script from Eventing so it was remained. - Add missing `make RELEASE=ci generate-release`, which is necessary to update the yaml after patched.
openshift-ci
Bot
added
the
approved
| fi | ||
| git apply $PATCH_DIR/* | ||
| make RELEASE=$release generate-release | ||
| make RELEASE=ci generate-release |
There was a problem hiding this comment.
I guess that simply adds the label "1.x.0" as done manually here #1136 and is also missing from https://github.com/openshift/knative-serving/blob/release-v1.4/openshift/release/knative-serving-ci.yaml correct?
Over time make generate-release was minimized to simply update labels it seems: https://github.com/openshift/knative-serving/blob/main/openshift/release/resolve.sh#L21-L23 (the comment there is wrong obviously).
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
When creating openshift/release#29082, there are two errors found.
make test-conformanceandmake test-reconcilerdoes not exist on serving. (I copied the script from Eventing and it was remained.make RELEASE=ci generate-release, which is necessary to update the yaml after patched./cc @skonto @mgencur