Add serving 1.5 job#29082
Merged
Merged
Conversation
openshift-ci
Bot
added
the
approved
Contributor
Author
|
/retest |
Contributor
Author
|
/test pj-rehearse |
nak3
added a commit
to nak3/serving
that referenced
this pull request
Jun 2, 2022
When creating openshift/release#29082, there are two errors found. - `make test-conformance` and `make test-reconciler` does not exist on serving. (I copied the script from Eventing so it was remained. - Add missing `make RELEASE=ci generate-release`, which is necessary to update the yaml after patched.
Contributor
Author
Contributor
|
@nak3: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
pushed a commit
to openshift/knative-serving
that referenced
this pull request
Jun 3, 2022
When creating openshift/release#29082, there are two errors found. - `make test-conformance` and `make test-reconciler` does not exist on serving. (I copied the script from Eventing so it was remained. - Add missing `make RELEASE=ci generate-release`, which is necessary to update the yaml after patched.
Contributor
|
@nak3 I guess we will adapt this when 4.11 is out? |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@nak3: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title this patch adds serving 1.5 job.