Skip to content

Add serving 1.6 job#30877

Merged
openshift-merge-robot merged 4 commits into
openshift:masterfrom
nak3:add-1.6
Aug 1, 2022
Merged

Add serving 1.6 job#30877
openshift-merge-robot merged 4 commits into
openshift:masterfrom
nak3:add-1.6

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented Jul 28, 2022

This is similar to #29082

@openshift-ci openshift-ci Bot requested review from bbguimaraes and mvinkler July 28, 2022 02:15
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@nak3
Revert "Add 4.11"
fa0e337 
This reverts commit b4fb169.
@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Jul 28, 2022

4.11 seems not available yet.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Jul 28, 2022

/cc @skonto @mgencur

@openshift-ci openshift-ci Bot requested review from mgencur and skonto July 28, 2022 05:52
@skonto
Copy link
Copy Markdown
Contributor

skonto commented Jul 28, 2022

/hold for tests
/lgtm
Let's do the 4.11 update for all stuff when that version is out.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
skonto
skonto reviewed Jul 28, 2022
View reviewed changes
Comment thread ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.6__410.yaml
product: ocp
timeout: 1h0m0s
version: "4.10"
cron: 0 15 * * 1-5
Copy link
Copy Markdown
Contributor

@skonto skonto Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we shift this to avoid runs at the same time?
I see that the job for 1.5 has 0 13 * * 1-5.

Copy link
Copy Markdown
Contributor Author

@nak3 nak3 Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct.
Here is the script https://github.com/openshift/knative-serving/blob/main/openshift/ci-operator/generate-ci-config.sh#L45-L69

skonto
skonto reviewed Jul 28, 2022
View reviewed changes
Comment thread ...perator/jobs/openshift/knative-serving/openshift-knative-serving-release-v1.6-periodics.yaml
@@ -0,0 +1,76 @@
periodics:
- agent: kubernetes
cluster: build01
Copy link
Copy Markdown
Contributor

@skonto skonto Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pick build01 to try spread the load (1.5 has build02)?

Copy link
Copy Markdown
Contributor Author

@nak3 nak3 Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was assigned by this repo's make jobs. And the auto-bot sometimes distributes the cluster like 77123db so let's leave it as it is.

@skonto
Copy link
Copy Markdown
Contributor

skonto commented Jul 28, 2022 

type"="" "vcs-url"=""
COMMIT temp.builder.openshift.io/ci-op-ylcy4vvw/test-bin:8f56fde5
time="2022-07-28T03:27:17Z" level=warning msg="Adding metacopy option, configured globally", the build test-bin failed after 6m16s with reason OutOfMemoryKilled: The build pod was killed due to an out of memory condition.

/retest

@skonto
Copy link
Copy Markdown
Contributor

skonto commented Jul 28, 2022 •
edited
Loading

This is weird 4.6, 4.8 images passed but 4.7, 4.10 failed with the out of memory issue. I am wondering if the current setting is high enough. In the jobs I see 2Gi.

@skonto
Copy link
Copy Markdown
Contributor

skonto commented Jul 28, 2022

/retest

2 similar comments
@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Jul 29, 2022

/retest

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Jul 29, 2022

/retest

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Jul 29, 2022

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 29, 2022 •
edited
Loading

@nak3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/knative-serving/release-v1.6/411-e2e-aws-ocp-411 b4fb169 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-knative-serving-release-v1.6-411-e2e-aws-ocp-411-continuous b4fb169 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Jul 29, 2022

/retest

@skonto
Copy link
Copy Markdown
Contributor

skonto commented Aug 1, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@skonto
Copy link
Copy Markdown
Contributor

skonto commented Aug 1, 2022

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 72d25d2 into openshift:master Aug 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 1, 2022

@nak3: Updated the following 3 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-v1.6__410.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.6__410.yaml
    • key openshift-knative-serving-release-v1.6__46.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.6__46.yaml
    • key openshift-knative-serving-release-v1.6__47.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.6__47.yaml
    • key openshift-knative-serving-release-v1.6__48.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.6__48.yaml
    • key openshift-knative-serving-release-v1.6__49.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-v1.6__49.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-v1.6-periodics.yaml using file ci-operator/jobs/openshift/knative-serving/openshift-knative-serving-release-v1.6-periodics.yaml
    • key openshift-knative-serving-release-v1.6-postsubmits.yaml using file ci-operator/jobs/openshift/knative-serving/openshift-knative-serving-release-v1.6-postsubmits.yaml
    • key openshift-knative-serving-release-v1.6-presubmits.yaml using file ci-operator/jobs/openshift/knative-serving/openshift-knative-serving-release-v1.6-presubmits.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_knative_v1_6_quay using file core-services/image-mirroring/knative/mapping_knative_v1_6_quay
Details

In response to this:

This is similar to #29082

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3 nak3 mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@mvinkler mvinkler Awaiting requested review from mvinkler

@mgencur mgencur Awaiting requested review from mgencur

1 more reviewer

@skonto skonto skonto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@skonto skonto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nak3 @skonto @openshift-merge-robot