[RELEASE-1.5] Fix pdb version#1195
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@skonto: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@nak3 gentle ping |
|
/hold I think the pdb issue should be fixed by code instead of this API patch. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
Is this a temporary patch? Once we merge this, I guess nobody takes care of the PDB issue until OCP 4.12 CI becomes ready. |
|
Yes this is temporary. At some point we will need to fix it in code. |
|
So, where (which CI) needs this temporary patch now? |
|
When we move to 1.5 at the S-O we might dont have 4.12 out and so this patch will still be useful. It is also an option to wait and see. Wfm. |
|
If no rush, I am prefer to hold this and merge when the S-O bumps to 1.5 if the code was not implemented. Also it is very tiny thing, but if we merge this patch, we may need to implement the code by the version translation from |
|
ok sure /hold |
|
Closing this as we are going to address similar issues at the s-o side. |
2 participants
Similar to #1194.
Pdb beta version was deprecated in v1.21+ and will be removed with K8s 1.25+, OCP 4.12.
It seems promotion to v1 came up in 1.21 (OCP 4.8?). It means that even if 4.6 is removed we will still have to support beta for 4.7. Thus with 4.12 we might need to detect the OCP version and patch manifests accordingly at the S-O until 4.7 is gone?
/assign @nak3