Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

[RELEASE-1.5] Image injection#1189

Merged
openshift-merge-robot merged 4 commits into
openshift:release-v1.5from
skonto:image_injection_1.5
Jul 27, 2022
Merged

[RELEASE-1.5] Image injection#1189
openshift-merge-robot merged 4 commits into
openshift:release-v1.5from
skonto:image_injection_1.5

Conversation

@skonto
Copy link
Copy Markdown

@skonto skonto commented Jul 27, 2022

  • Part of the SIG release work
  • Adds the required commits as in 1.4.

skonto and others added 4 commits July 27, 2022 10:51
* inject images, generate manifests (knative#1150)

* Revert temoprary branch for image injection (knative#1159)

Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
@skonto
Copy link
Copy Markdown
Author

skonto commented Jul 27, 2022

/assign @nak3

@skonto skonto requested a review from nak3 July 27, 2022 08:13
@openshift-ci openshift-ci Bot requested review from mgencur and mvinkler July 27, 2022 08:13
@skonto skonto changed the title Image injection for 1.5 [RELEASE-1.5] Image injection Jul 27, 2022
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@skonto skonto removed request for mgencur and mvinkler July 27, 2022 08:43
@nak3
Copy link
Copy Markdown

nak3 commented Jul 27, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 27, 2022

@skonto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e5083cd into openshift:release-v1.5 Jul 27, 2022
@skonto skonto mentioned this pull request Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants