This repository was archived by the owner on Dec 1, 2022. It is now read-only.
[RELEASE-1.6] Image injection #1190
Merged
openshift-merge-robot merged 4 commits intoAug 1, 2022
Merged
Conversation
* inject images, generate manifests (knative#1150) * Revert temoprary branch for image injection (knative#1159) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
openshift-ci
Bot
added
the
approved
Author
|
/hold we dont have ci here |
openshift-ci
Bot
added
the
do-not-merge/hold
Author
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@skonto: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Author
|
@nak3 gentle ping. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in #1189