Bump to kubernetes-v1.18.2 by marun · Pull Request #122 · openshift/kubernetes

marun · 2020-04-22T04:57:57Z

TODO:

https://docs.google.com/spreadsheets/d/10KYptJkDB1z8_RYCQVBYDjdTlRfyoXILMa0Fg8tnNlY/edit#gid=1388579334

marun · 2020-04-22T04:59:08Z

make verify has a ton of failures:

FAILED TESTS
========================
hack/make-rules/../../hack/verify-api-groups.sh
hack/make-rules/../../hack/verify-boilerplate.sh
hack/make-rules/../../hack/verify-conformance-requirements.sh
hack/make-rules/../../hack/verify-external-dependencies-version.sh
hack/make-rules/../../hack/verify-generated-files-remake.sh
hack/make-rules/../../hack/verify-golint.sh
hack/make-rules/../../hack/verify-govet.sh
hack/make-rules/../../hack/verify-import-aliases.sh
hack/make-rules/../../hack/verify-no-vendor-cycles.sh
hack/make-rules/../../hack/verify-openapi-spec.sh
hack/make-rules/../../hack/verify-spelling.sh
hack/make-rules/../../hack/verify-staticcheck.sh
hack/make-rules/../../hack/verify-typecheck-providerless.sh
hack/make-rules/../../hack/verify-typecheck.sh
hack/make-rules/../../hack/verify-vendor.sh
hack/make-rules/../../hack/verify-publishing-bot.py

I'm assuming something trivial is wrong here given that rc.1 passed all of these tests and the changes between 1.18.0-rc.1 and 1.18.2 are minimial.

openshift-ci-robot · 2020-04-22T04:59:39Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marun
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS
staging/src/k8s.io/api/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

marun · 2020-04-22T05:25:06Z

3 unit tests are failing, all in oom_watcher_linux_test.go:

https://gist.github.com/marun/2e5662ab60eb34ca0de12c0f0a337f30

This despite carrying the rc.1 fix.

p0lyn0mial · 2020-04-22T07:43:28Z

I think that the following commits are missing.

274c12a (UPSTREAM: 90234: Remove PreStop hook from hostpath CSI driver)
5db3ed9 (UPSTREAM: 90254: IngressClass error test is flaky)
bed688b (UPSTREAM: 89833: kube-openapi bump to release-1.18)
b0c1c91 (UPSTREAM: : Increate timeout in volume expansion test)

marun · 2020-04-22T09:04:40Z

I think that the following commits are missing.

274c12a (UPSTREAM: 90234: Remove PreStop hook from hostpath CSI driver)

5db3ed9 (UPSTREAM: 90254: IngressClass error test is flaky)

bed688b (UPSTREAM: 89833: kube-openapi bump to release-1.18)

b0c1c91 (UPSTREAM: : Increate timeout in volume expansion test)

Good catch, fixed.

openshift-ci-robot · 2020-04-22T09:09:47Z

@marun: This pull request references Bugzilla bug 1826230, which is invalid:

expected Bugzilla bug 1826230 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1826230: Bump to kubernetes-v1.18.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-22T09:11:00Z

@marun: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bump to kubernetes-v1.18.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-22T20:12:57Z

@marun: This pull request references Bugzilla bug 1826230, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1826230 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1826230: Bump to kubernetes-v1.18.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2020-04-22T20:14:00Z

/bugzilla refresh

openshift-ci-robot · 2020-04-22T20:14:02Z

@marun: This pull request references Bugzilla bug 1826230, which is invalid:

expected Bugzilla bug 1826230 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-23T01:04:15Z

@marun: This pull request references Bugzilla bug 1826230, which is invalid:

expected Bugzilla bug 1826230 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1826230: Bump to kubernetes-v1.18.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2020-04-23T01:06:27Z

The unit test failures ended up being due to /dev/ksmg being set readable by non-root on my workstation. Apparently that's not the default so the tests will pass on the average system.

openshift-ci-robot · 2020-04-23T11:30:30Z

@marun: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bump to kubernetes-v1.18.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…o function Origin-commit: 0d7fb2d769d631054ec9ac0721aee623c96c1001

Origin-commit: cb0b340d0e68c9524fa7fd6277f571b6aa68bf86

The following packages have tests that exceed the default 120s timeout: k8s.io/kubernetes/pkg/kubelet/volumemanager/reconciler - The tests in this package collectively take longer than 120s. k8s.io/kubernetes/pkg/volume/csi - One of the unit tests has to wait 2 minutes for a timeout to validate its failure condition.

…nknown labels

Origin-commit: c0ff1ad9899a1c9db21186e1a02eec35673fb357

Signed-off-by: Ted Yu <zyu@redhat.com> Origin-commit: 1d753cc478134dd84ad9cfdbd166659505da8b6f

… secret This patch brings back the downstream changes that were introduced to allow reading openstack cloud provider config from a secret. They are available in release-4.4, but were reverted in master with openshift/origin#24719 This change includes: - Ability to read metadata values for kubelet. Since the service does not have access to the secret to read the configuration, but it needs data to download (e.g. hostname or flavor), we are trying to get it from the metadata server. - Deprecation of kubeConfig parameter. Now we read the file that was provided with --kubeconfig option. Origin-commit: f95edc26155a29769b3c5b80c03755a01a87b5fc

…t tests)

…alization during Kubelet init

…y test failure

Origin-commit: 648d8f84875920df4a6509ec4c1677859117968a

Origin-commit: f85c00e875ec57e4ff7f45db4b917e94b889e760

Origin-commit: 7ca0dd0a3be3fd2c3bcf51deff76b7e76f95dcd0

The test races with the admission cache and is failing 5-7% of the time in e2e runs. Origin-commit: 3a6baaf17e355b30f37b89400e6e16510c5b32d7

The resource quota priority class preemption tests run in parallel, and were observed to cause a preemption of another test. The tests have no need to schedule to a node in order to verify resource quota. ``` Apr 19 16:59:06.749: INFO: At 2020-04-19 16:58:52 +0000 UTC - event for pod-init-b6fbd440-dbc2-454a-b31a-ce44266298d1: {default-scheduler } Scheduled: Successfully assigned e2e-init-container-7691/pod-init-b6fbd440-dbc2-454a-b31a-ce44266298d1 to ip-10-0-148-234.us-west-2.compute.internal Apr 19 16:59:06.750: INFO: At 2020-04-19 16:58:54 +0000 UTC - event for pod-init-b6fbd440-dbc2-454a-b31a-ce44266298d1: {default-scheduler } Preempted: Preempted by e2e-resourcequota-priorityclass-8850/testpod-pclass9 on node ip-10-0-148-234.us-west-2.compute.internal ``` Origin-commit: a0780b385ca58a02e04ea8498df2fffa6cbc1275

They are useless and only pollute logs with errors. Origin-commit: dc7ec4d52f7a3dea0f1e04ae24856236c2765557

Origin-commit: 61a14d76dcc6578a409385730742d967fd4fe606

openshift-ci-robot requested review from p0lyn0mial and sttts April 22, 2020 04:57

openshift-ci-robot added the area/dependency Issues or PRs related to dependency changes label Apr 22, 2020

marun force-pushed the origin-4.5-kubernetes-1.18.2 branch from beb9586 to a5f8904 Compare April 22, 2020 09:01

marun changed the title ~~Bump to kubernetes-v1.18.2~~ Bug 1826230: Bump to kubernetes-v1.18.2 Apr 22, 2020

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Apr 22, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 22, 2020

marun changed the title ~~Bug 1826230: Bump to kubernetes-v1.18.2~~ Bump to kubernetes-v1.18.2 Apr 22, 2020

openshift-ci-robot removed bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 22, 2020

marun force-pushed the origin-4.5-kubernetes-1.18.2 branch from a5f8904 to 0b7be6e Compare April 22, 2020 20:10

marun changed the title ~~Bump to kubernetes-v1.18.2~~ Bug 1826230: Bump to kubernetes-v1.18.2 Apr 22, 2020

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Apr 22, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 22, 2020

soltysh changed the title ~~Bug 1826230: Bump to kubernetes-v1.18.2~~ Bump to kubernetes-v1.18.2 Apr 23, 2020

openshift-ci-robot removed the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Apr 23, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 23, 2020

deads2k and others added 26 commits April 28, 2020 00:08

UPSTREAM: <carry>: simplify the authorizer patch to allow the flags t…

cb9f123

…o function Origin-commit: 0d7fb2d769d631054ec9ac0721aee623c96c1001

UPSTREAM: 88120: add dynamic certificate reloading for kube aggregator

9003784

Origin-commit: cb0b340d0e68c9524fa7fd6277f571b6aa68bf86

UPSTREAM: <carry>: Supply context to API calls

bbc2d50

UPSTREAM: 89145: apiextensions: wait for complete discovery endpoint

f183ee2

UPSTREAM: <carry>: CHECK(node): disable --node-label validation for u…

d55737e

…nknown labels

UPSTREAM: 89300: Expand the PVC validation messages

7c4568d

Origin-commit: c0ff1ad9899a1c9db21186e1a02eec35673fb357

UPSTREAM: 88006: Unregister csiplugin even if socket path is gone

9d18094

Signed-off-by: Ted Yu <zyu@redhat.com> Origin-commit: 1d753cc478134dd84ad9cfdbd166659505da8b6f

UPSTREAM: 89580: kubelet: skip oom test if NewWatcher errors (non-roo…

c48b6b5

…t tests)

UPSTREAM: 89736: Fix linux volume unit test

d2c0c5d

UPSTREAM: 89589: Wait for APIServer 'ok' forever during CSINode initi…

cc9ca1d

…alization during Kubelet init

UPSTREAM: 89592: e2e/network: get previous pod errors on NetworkPolic…

22a3f4d

…y test failure

UPSTREAM: <drop>: Increate timeout in volume expansion test

4999188

Origin-commit: 648d8f84875920df4a6509ec4c1677859117968a

UPSTREAM: 89172: Fix mountOptions in iSCSI and FC volume plugins

86ca246

Origin-commit: f85c00e875ec57e4ff7f45db4b917e94b889e760

UPSTREAM: 89833: Preserve int/float distinction when decoding raw values

1b44738

Origin-commit: 7ca0dd0a3be3fd2c3bcf51deff76b7e76f95dcd0

UPSTREAM: 90254: IngressClass error test is flaky

c96e6ab

The test races with the admission cache and is failing 5-7% of the time in e2e runs. Origin-commit: 3a6baaf17e355b30f37b89400e6e16510c5b32d7

UPSTREAM: 90234: Remove PreStop hook from hostpath CSI driver

306865d

They are useless and only pollute logs with errors. Origin-commit: dc7ec4d52f7a3dea0f1e04ae24856236c2765557

UPSTREAM: 90147: relax zone requirement from e2e

3a9c811

Origin-commit: 61a14d76dcc6578a409385730742d967fd4fe606

UPSTREAM: <drop>: bump(*)

6df7901

UPSTREAM: <carry>: Skip unnecessary verify checks

ffcf7f6

UPSTREAM: <drop>: hack/update-gofmt.sh

e8b79db

UPSTREAM: <drop>: hack/update-vendor-licenses.sh

807c4cb

UPSTREAM: <drop>: make generated_files

d48f214

UPSTREAM: <drop>: make update

8c8387d

marun force-pushed the origin-4.5-kubernetes-1.18.2 branch from 1f4f4f9 to 8c8387d Compare April 28, 2020 07:09

marun mentioned this pull request Apr 28, 2020

Bug 1821352: vendor: Bump to pick up onsi/ginkgo panic reporting openshift/origin#24916

Closed

sttts merged commit 35c8cde into openshift:origin-4.5-kubernetes-1.18.2 Apr 29, 2020

marun deleted the origin-4.5-kubernetes-1.18.2 branch April 30, 2020 04:17

Conversation

marun commented Apr 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marun commented Apr 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

marun commented Apr 22, 2020

Uh oh!

p0lyn0mial commented Apr 22, 2020

Uh oh!

marun commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

marun commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 23, 2020

Uh oh!

marun commented Apr 23, 2020

Uh oh!

openshift-ci-robot commented Apr 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

marun commented Apr 22, 2020 •

edited

Loading

marun commented Apr 22, 2020 •

edited

Loading